Replace pytz with standard library's zoneinfo#2343
Draft
markcampanelli wants to merge 16 commits intopvlib:mainfrom
Draft
Replace pytz with standard library's zoneinfo#2343markcampanelli wants to merge 16 commits intopvlib:mainfrom
markcampanelli wants to merge 16 commits intopvlib:mainfrom
Conversation
This was referenced Dec 23, 2024
Member
|
@markcampanelli I'm marking this change for v0.13.0. I think the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a demonstration of how we could remove the direct dependency on
pytzand adopt the IANA-compliant standard-library solutionzoneinfo, available since Python 3.9. This also leads to a single-source-of-truth simplification of the timezone tracking inpvlib.location.Location. Note thatpandasapparently still usespytzextensively, but I did not find this to conflict.TODO:
[ ] Update the extensive timezone tutorial in
timetimezones.rst.docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.