Skip to content

Support for mixed precip/noprecip input and AR order 1#544

Draft
ladc wants to merge 15 commits intomasterfrom
precip-noprecip_input_fix_and_ar_order-1_fix_issue543
Draft

Support for mixed precip/noprecip input and AR order 1#544
ladc wants to merge 15 commits intomasterfrom
precip-noprecip_input_fix_and_ar_order-1_fix_issue543

Conversation

@ladc
Copy link
Copy Markdown
Contributor

@ladc ladc commented Mar 27, 2026

Fix several issues in case of intermittent rainfall in the radar images:

  • Fix mixed rain/norain input frames
  • Add tests
  • Make AR1 work for regular steps
  • Add tests
  • Make AR1 work for steps blending
  • Add tests

Works towards fixing issue #543.

Reduce overall number of tests and refactor code
Add dedicated AR order parameterization
@ladc ladc force-pushed the precip-noprecip_input_fix_and_ar_order-1_fix_issue543 branch from 2e24248 to 5170768 Compare March 27, 2026 12:44
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 92.18750% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.19%. Comparing base (29a317b) to head (e605150).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pysteps/blending/steps.py 74.07% 7 Missing ⚠️
pysteps/nowcasts/steps.py 72.22% 5 Missing ⚠️
pysteps/blending/skill_scores.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   83.89%   84.19%   +0.29%     
==========================================
  Files         168      170       +2     
  Lines       14678    14985     +307     
==========================================
+ Hits        12314    12616     +302     
- Misses       2364     2369       +5     
Flag Coverage Δ
unit_tests 84.19% <92.18%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Precip + no-precip input time steps cause blending failure AND in general ar_order=1 causes blending failure

2 participants