Skip to content

Apply some important fixes#579

Merged
yguclu merged 23 commits intodevelfrom
some_fixes
Mar 25, 2026
Merged

Apply some important fixes#579
yguclu merged 23 commits intodevelfrom
some_fixes

Conversation

@yguclu
Copy link
Copy Markdown
Member

@yguclu yguclu commented Mar 22, 2026

  • Use pyccel >= 2.2.3: this allows compiling all kernels with C
  • Require h5py >= 3.16 to allow for standard install with setuptools >= 81.0
  • Require numpy >= 2.1 to support Python >= 3.10
  • Use pytest.toml instead of pytest.ini for Pytest configuration (requires pytest >= 9.0)
  • Move coverage configuration from pyproject.toml to psydac/pytest.toml
  • Don't run postprocessing unit tests with pytest-xdist because h5py is not thread-safe: add Pytest mark @pytest.mark.xdist_group('h5py') to all unit tests in psydac/api/tests/test_postprocessing.py
  • Return error code on failure of the psydac test command; this was not correctly returned before, hence the CI could not detect when the unit tests were failing in a subprocess
  • Return error code on failure of the psydac compile command; this fix does not directly affect the CI, but it is included for correctness.
  • Check correct reporting of failure for psydac test command in CI testing
  • Use correct configuration file in coverage CI tests
  • For clarity, rename temporary folder where all CI tests are run: pytest -> scratch
  • Clean up .gitignore; specifically, stop ignoring files which don't exist anymore

@yguclu yguclu marked this pull request as ready for review March 23, 2026 10:40
@yguclu yguclu added testing Unit tests, coverage, benchmarks CLI Command Line Interface labels Mar 23, 2026
@yguclu yguclu marked this pull request as draft March 23, 2026 16:12
@yguclu yguclu marked this pull request as ready for review March 23, 2026 16:12
@yguclu yguclu marked this pull request as draft March 23, 2026 18:35
@yguclu yguclu marked this pull request as ready for review March 23, 2026 18:35
@yguclu yguclu marked this pull request as draft March 24, 2026 09:37
@yguclu yguclu marked this pull request as ready for review March 24, 2026 09:37
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Mar 24, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+4.94% 28.57%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (16fb9d3) 31788 19587 61.62%
Head commit (637a38f) 98952 (+67164) 65858 (+46271) 66.56% (+4.94%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#579) 35 10 28.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@yguclu yguclu marked this pull request as draft March 24, 2026 11:08
@yguclu yguclu marked this pull request as ready for review March 24, 2026 11:08
@yguclu yguclu marked this pull request as draft March 24, 2026 12:16
@yguclu yguclu marked this pull request as ready for review March 24, 2026 12:16
@yguclu yguclu marked this pull request as draft March 24, 2026 12:29
@yguclu yguclu marked this pull request as ready for review March 24, 2026 12:29
@yguclu yguclu marked this pull request as draft March 24, 2026 13:07
@yguclu yguclu marked this pull request as ready for review March 24, 2026 13:07
@yguclu yguclu marked this pull request as draft March 24, 2026 15:20
@yguclu yguclu marked this pull request as ready for review March 24, 2026 15:20
@yguclu yguclu marked this pull request as draft March 24, 2026 21:40
@yguclu yguclu marked this pull request as ready for review March 24, 2026 21:40
@yguclu yguclu requested review from a team and campospinto March 24, 2026 22:17
@yguclu yguclu requested a review from kvrigor March 25, 2026 09:16
Copy link
Copy Markdown
Collaborator

@campospinto campospinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a lot of improvements, thanks ! I can only do a shallow review but it seems good to me. I just have one question mostly to clarify a point.

@yguclu yguclu merged commit 554017e into devel Mar 25, 2026
10 checks passed
@yguclu yguclu deleted the some_fixes branch March 25, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI Command Line Interface testing Unit tests, coverage, benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants