Open
Conversation
sjsrey
reviewed
Apr 18, 2026
| mi1 = moran.Moran_Rate(self.e, self.b, w, permutations=99, seed=SEED) | ||
| mi2 = moran.Moran_Rate(self.e, self.b, w, permutations=99, seed=SEED + 1) | ||
| np.testing.assert_allclose(mi1.I, mi2.I) | ||
| assert mi1.p_sim != mi2.p_sim |
Member
There was a problem hiding this comment.
The p_sim is likely to be the same even with different seeds due to the same level of spatial autocorrelation in the data. Maybe better to omit the test on this attribute here, since you do check if the sim values differ with different seeds.
sjsrey
reviewed
Apr 18, 2026
|
|
||
| def __init__(self, x, y, w, transformation="r", permutations=PERMUTATIONS): | ||
| def __init__( | ||
| self, x, y, w, transformation="r", permutations=PERMUTATIONS, seed=None |
Member
There was a problem hiding this comment.
The docstring should be updated to reflect the new parameter.
sjsrey
requested changes
Apr 18, 2026
Member
sjsrey
left a comment
sjsrey
left a comment
There was a problem hiding this comment.
Thanks for this.
Some comments to help with test failures, and alignment with SPEC 07
|
|
||
| def __init__(self, x, y, w, transformation="r", permutations=PERMUTATIONS): | ||
| def __init__( | ||
| self, x, y, w, transformation="r", permutations=PERMUTATIONS, seed=None |
Member
There was a problem hiding this comment.
We are adopting spec 07 across pysal, and this recommends deprecating the seed argument infavor of an rng argument.
| transformation="r", | ||
| permutations=PERMUTATIONS, | ||
| two_tailed=True, | ||
| seed=None, |
| transformation=transformation, | ||
| permutations=permutations, | ||
| two_tailed=two_tailed, | ||
| seed=seed, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added seed parameter to Moran_BV and Moran_Rate to enable reproducible permutation-based significance testing, and update Moran_BV to use the NumPy Generator API.
Changes
esda/moran.py:esda/tests/test_moran.py: