gh-143883: Add missing named parameters in public PyModExport C bindings

[ngoldbaum]

See the linked issue for details.

• Issue: PyModule_FromSlotsAndSpec and PyModule_GetToken exposed without named parameters #143883

[ngoldbaum]

ping @encukou since you wrote this code originally

[ngoldbaum]

Looks like unrelated CI issues are causing the failures

[encukou]

Thanks for the catch!
While you're here, could you rename the others to module (rather than mod), and add a missing name to docs?
Or let me know if I should take over.

(Failures are indeed unrelated: Ubuntu was down)

[ngoldbaum]

I did some minor wording tweaks in the docs to adapt to the name changes, let me know if you have suggestions there.

[encukou]

Hi! Sorry, I wasn't clear above.

If the argument names matter, it'd be better to avoid abbrevs: module rather than mod.
I've sent a PR to your branch, does it look good? ngoldbaum#1

[vstinner]

LGTM. I also prefer to use the name "module" instead of "mod".

[da-woods]

Quick note: module is a "soft-keyword" in C++20. So it's fine to use it as an argument name, but I had to do a little bit of reading to convinced myself that this was actually true.

[vstinner]

Quick note: module is a "soft-keyword" in C++20. So it's fine to use it as an argument name, but I had to do a little bit of reading to convinced myself that this was actually true.

I modified locally test_cppext to test C++20. I confirm that the usage of the module name is fine with C++20.

[encukou]

Re-reading this, “the module module“ is repetitive. Sorry for not catching this earlier.

I'll merge after I check the rendered docs for this.

[encukou]

We've been declaring a module argument elsewhere for over a decade :)