Add logging message to notify user of skipped benchmarks#316
Open
bclodius wants to merge 2 commits intopython:mainfrom
Open
Add logging message to notify user of skipped benchmarks#316bclodius wants to merge 2 commits intopython:mainfrom
bclodius wants to merge 2 commits intopython:mainfrom
Conversation
hugovk
reviewed
Oct 9, 2023
Author
|
@hugovk thanks for your feedback, I believe I've incorporated it all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Hello!
I was recently running a number of benchmarks to analyze a migration to different python3 versions as well as different server infrastructure.
In my first 30-60 minutes playing with this library I was very confused that my results would only show benchmarks for
comprehensionsandsqlglot. After some breadcrumbs and print statements I finally came to realize that a large majority of the benchmarks require>=3.8. I was testing on a version of python 3.7.I was hoping this small enhancement would help other users in future to prevent hair pulling and headaches!
Testing
Before
After