Enable decimal_pi benchmark in the suite (MANIFEST)#453
Open
skirpichev wants to merge 3 commits intopython:mainfrom
Open
Enable decimal_pi benchmark in the suite (MANIFEST)#453skirpichev wants to merge 3 commits intopython:mainfrom
skirpichev wants to merge 3 commits intopython:mainfrom
Conversation
They were not added here in python#341 for no reasons.
hugovk
reviewed
Jan 19, 2026
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
approved these changes
Jan 19, 2026
Member
|
cc @mdboom in case there was a reason to omit them. |
Member
Author
|
Ah, pypy3 failure seems relevant. decimal_factorial looks too slow on PyPy3 (with only pure-Python version of the decimal module). |
skirpichev
commented
Jan 20, 2026
hugovk
changed the title
Member
Author
|
@hugovk, anything else? I think we can enable decimal_factorial test, but this will need a workaround for pure-Python decimal module. The presence of accelerated module we can detect, trying to import the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were not added here in #341 for no reasons.