security: fix DUMMY_HASH, timing jitter, and sub-token scan limit#25
Open
security: fix DUMMY_HASH, timing jitter, and sub-token scan limit#25
Conversation
- Replace invalid 36-char DUMMY_HASH with valid 60-char BCrypt hash to prevent user enumeration via timing side-channel - Replace fixed 100ms Thread.sleep floor with randomized 80-120ms jitter to improve timing normalization and reduce thread exhaustion risk - Limit sub-token validation fallback scan to maxClients entries to bound worst-case BCrypt comparisons - Remove SECURITY-AUDIT.md - Update security and performance docs to reflect changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent user enumeration via timing side-channel
to improve timing normalization and reduce thread exhaustion risk
bound worst-case BCrypt comparisons