Draft
Conversation
To resolve ``` quarto:dev: ✘ [ERROR] Could not resolve "positron" quarto:dev: quarto:dev: src/host/hooks.ts:19:23: quarto:dev: 19 │ import * as hooks from 'positron'; ```
DavisVaughan
commented
Feb 18, 2026
Comment on lines
+218
to
+226
| // TODO: Remove this once `apps/vscode/package.json` bumps to `"positron": "^2026.03.0"` or higher. | ||
| // For now we avoid aggressive bumping due to https://github.com/posit-dev/positron/issues/11321. | ||
| if (semver.gte(hooks.version, "2026.03.0")) { | ||
| if (err instanceof hooks.StatementRangeSyntaxError) { | ||
| // Rethrow syntax error with unadjusted line number, so Positron's notification will | ||
| // jump to the correct line | ||
| throw new hooks.StatementRangeSyntaxError(err.line ? unadjustedLine(vdoc.language, err.line) : undefined); | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Version guarding on the expected next positron release of "2026.03.0"
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatementRangeSyntaxErrorposit-dev/positron#11907 first, with finalized type namesIt feels to me like we should still use the "old"
hooks.d.tssystem for this, becauseStatementRangeis already tied up in thathooks.d.tsfile. Mixinghooks.d.tsand types from@posit-dev/positrondoesn't feel like it would be a very good idea for this extension of an existing feature, IIUC.IIUC, we can technically go ahead and merge this even without the next Positron release due to the version guard.