Fix flaky test TestSubscribeWithContextDone#187
Open
n-peugnet wants to merge 1 commit intor3labs:masterfrom
Open
Fix flaky test TestSubscribeWithContextDone#187n-peugnet wants to merge 1 commit intor3labs:masterfrom
n-peugnet wants to merge 1 commit intor3labs:masterfrom
Conversation
n-peugnet
force-pushed
the
fix-flaky-test
branch
from
9b4d8c2 to
46185f2
Compare
Instead of comparing the number of goroutines which is inherently unreliable, we count the number of goroutines that exited using a defer statement, and an atomic counter. By the way, the timer are reduced to 10ms as it is more than enough time to let the goroutines exit. Closes: r3labs#186
n-peugnet
force-pushed
the
fix-flaky-test
branch
from
46185f2 to
e997268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of comparing the number of goroutines which is inherently unreliable, we count the number of goroutines that exited using a defer statement, and an atomic counter.
By the way, the timer are reduced to 100ms as it is more than enough time to let the goroutines exit.
Closes: #186