Skip to content

refactor(proto): regenerate protos after gateway annotations removed#1436

Merged
whoAbhishekSah merged 2 commits intomainfrom
refactor/update-proton-remove-gateway-annotations
Mar 3, 2026
Merged

refactor(proto): regenerate protos after gateway annotations removed#1436
whoAbhishekSah merged 2 commits intomainfrom
refactor/update-proton-remove-gateway-annotations

Conversation

@whoAbhishekSah
Copy link
Member

Summary

Context

This PR depends on proton#444 being merged first. Once proton#444 is merged, the PROTON_COMMIT should be updated to the merge commit SHA on main.

Test plan

  • make proto succeeds
  • go build ./... passes
  • make test passes (all unit tests green)

🤖 Generated with Claude Code

…ns removed)

Update PROTON_COMMIT to d93715a (proton PR #444) which removes all
openapiv2 and google.api.http annotations from frontier proto files.
These annotations were only used by the now-removed gRPC-gateway server.

Regenerated proto files are ~4,000 lines smaller as the openapiv2
metadata is no longer embedded in the Go code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Mar 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Mar 3, 2026 7:36am

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ee8229 and 6223be0.

📒 Files selected for processing (1)
  • Makefile
🚧 Files skipped from review as they are similar to previous changes (1)
  • Makefile

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the build tooling to use a newer Proton release for protobuf generation, ensuring proto artifacts are produced with the latest upstream fixes and improvements. This is a non-functional infra change that may affect reproducible builds and proto outputs but does not alter application behavior.

Walkthrough

The Makefile's PROTON_COMMIT variable was changed from commit 330c7558f34570056814d418f99730fb45cfe80f to f8f6cd5b271d387cb99847a87b02a873df5b00ea, altering which Proton archive is downloaded for protobuf generation.

Changes

Cohort / File(s) Summary
Makefile Version Update
Makefile
Changed PROTON_COMMIT from 330c7558f34570056814d418f99730fb45cfe80f to f8f6cd5b271d387cb99847a87b02a873df5b00ea, updating the Proton commit used for proto generation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@whoAbhishekSah whoAbhishekSah changed the title refactor(proto): regenerate protos from proton#444 (gateway annotations removed) refactor(proto): regenerate protos after gateway annotations removed Mar 2, 2026
@coveralls
Copy link

coveralls commented Mar 2, 2026

Pull Request Test Coverage Report for Build 22613025940

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.848%

Totals Coverage Status
Change from base Build 22563274072: 0.0%
Covered Lines: 13595
Relevant Lines: 34117

💛 - Coveralls

@whoAbhishekSah whoAbhishekSah merged commit 73a14db into main Mar 3, 2026
8 checks passed
@whoAbhishekSah whoAbhishekSah deleted the refactor/update-proton-remove-gateway-annotations branch March 3, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants