Revert "Improve subtitle selection UX: Move "No Subtitles" option to bottom"#2720
Open
Luna712 wants to merge 1 commit intorecloudstream:masterfrom
Open
Revert "Improve subtitle selection UX: Move "No Subtitles" option to bottom"#2720Luna712 wants to merge 1 commit intorecloudstream:masterfrom
Luna712 wants to merge 1 commit intorecloudstream:masterfrom
Conversation
…bottom (…" This reverts commit ee6a9af.
Collaborator
|
I suppose that English is always a lot closer to the top than bottom, which would minimize the scrolling for an average user (assuming a primarily English speaking user base). It is truly difficult to decide which option is best. I think I like top subtitles more, but I need to do more testing on different devices before deciding to revert the change. |
Contributor
Author
|
Totally understandable, and yeah I dont really have an issue with it on Phone as scrolling is easier but it is inconvenient on TV. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2523
Reason for revert: while it being on the bottom may be more consistent, it is very hard to get used to and you have to scroll a lot more, especially on TV, to turn them off, which is poor UX IMO.
This can be closed if you decide you do not want to revert though.