RFC 2616 defines header values as case insensitive, so per default we…#1259
Open
notz wants to merge 1 commit intorestlet:2.3from
Open
RFC 2616 defines header values as case insensitive, so per default we…#1259notz wants to merge 1 commit intorestlet:2.3from
notz wants to merge 1 commit intorestlet:2.3from
Conversation
… should read/write headers values as case insensitive Currently only the getValues method use case insensitive per default, all other are case sensitive. This fixes problems behind a nginx reverse proxy, where "X-Forwarded-Proto" header is set as "X-forwarded-proto". The X-Forwarded-For is working because it's read in restlet with getValues method.
Contributor
|
Hi @notz , this is not so easy to change the default read option as this class is also used elsewhere. |
Author
|
I know that it's used everywhere. But the problem isn't my application.
It's used different in restlet and their modules. That's the correct
approach to fix problem. I know it is no small fix, but shouldn't break
anything because it's RFC conform.
…On Apr 22, 2017 15:23, "Thierry Boileau" ***@***.***> wrote:
Hi @notz <https://github.com/notz> , this is not so easy to change the
default read option as this class is also used elsewhere.
I have to check more deeply.
I think we can make sure that the framework internally reads the header in
the right way. In the cases you read the headers from your own code, is it
possible for you to read using the value in the case-insensitive way?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1259 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAqjozsHWlmptlhfEVbJLzOcaCfP9harks5ryf9hgaJpZM4MgYAC>
.
|
Author
|
@jlouvel Any chance to get this into 2.6? |
Collaborator
|
Hi @notz We could tackle this change in version 2.7 which along with 3.0 version will give us the opportunity to change the Restlet API and core behavior as needed, while 2,6 should stay as close as possible to 2.5 to streamline upgrades of production apps to Java 17 and Jakarta. See https://github.com/restlet/restlet-framework-java/wiki/Roadmap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… should read/write headers values as case insensitive
Currently only the getValues method use case insensitive per default, all other are case sensitive.
This fixes problems behind a nginx reverse proxy, where "X-Forwarded-Proto" header is set as "X-forwarded-proto" (#1191).
The X-Forwarded-For is working because it's read in restlet with getValues method.