Open
Conversation
royendo
requested review from
begelundmuller and
k-anshul
and removed request for
k-anshul
begelundmuller
requested changes
Apr 3, 2026
Comment on lines
+465
to
+469
| // Inject ClickHouse Cloud info for frontend consumption | ||
| m["is_clickhouse_cloud"] = c.isClickHouseCloud() | ||
| if host := c.resolvedHost(); host != "" { | ||
| m["resolved_host"] = host | ||
| } |
Contributor
There was a problem hiding this comment.
It's not safe/intended for Config to mutate the config before returning it
runtime/server/instances.go
Outdated
| // enrichConnectorWithRuntimeMetadata merges dynamic fields from the live OLAP connector handle | ||
| // into the proto connector config. This lets the frontend detect ClickHouse Cloud connectors | ||
| // even when the YAML config uses template variables (e.g. {{ .env.CLICKHOUSE_DSN }}). | ||
| func (s *Server) enrichConnectorWithRuntimeMetadata(ctx context.Context, instanceID string, pb *runtimev1.Instance) { |
Contributor
There was a problem hiding this comment.
This is way too hacky. This file is not even supposed to contain any driver-specific logic.
AdityaHegde
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status page today doesnt detect CHC properly shows up at
Clickhouse (self-managed)
Based on inputs of DSN or config properties
Checklist: