Open
Conversation
…rt creation The `await` on `queryClient.invalidateQueries` was blocking the form close and notification toast until the list resources query refetched. In CI, this could exceed Playwright's 5s assertion timeout, causing the "Should create alert with schedule" e2e test to flake. Changed to fire-and-forget (`void`) so the notification appears immediately after the mutation succeeds. The cache still invalidates in the background, and page navigations trigger fresh fetches anyway. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
oh the irony of getting flaky e2e tests when trying to fix a flaky e2e test |
invalidateQueries after alert/report creation
Collaborator
|
Looks like a rerun failed the tests. I am seeing console errors about submit (we do use I think the solution would be to make the form creation not be reactive. We would need to re-mount the component every time it is opened. Needs some testing to make sure we update the fields if explore changes. |
…ce breakage superForm() was inside a $: reactive block, causing it to be recreated whenever its dependencies changed. Since use:enhance only binds on mount, the new instance's enhance never got applied to the DOM, making form submission unreliable (especially under CI timing). Initialize superForm once when initialValues becomes available, using proper SuperForm<T> types instead of any. Guard the template until init completes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
await queryClient.invalidateQueries(...)was blocking the form close and notification toast until the list resources query refetchedvoid(fire-and-forget) so the notification appears immediately after the mutation succeeds; the cache still invalidates in the backgroundFlaky test: https://github.com/rilldata/rill/actions/runs/23904454966/job/69720769909
Checklist:
Developed in collaboration with Claude Code