Skip to content

fix: alert e2e failures due to form submission#9175

Merged
AdityaHegde merged 1 commit intomainfrom
fix/alert-form-submission-e2e
Apr 6, 2026
Merged

fix: alert e2e failures due to form submission#9175
AdityaHegde merged 1 commit intomainfrom
fix/alert-form-submission-e2e

Conversation

@AdityaHegde
Copy link
Copy Markdown
Collaborator

@AdityaHegde AdityaHegde commented Apr 3, 2026

Improve the alert form to be not reactive. This makes the form submission stable preventing E2E failures.

This adds a wrapper for loading data to keep explore state in sync with alert form. Moves the form itself inside with form instantiation as a non-reactive statement.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde force-pushed the fix/alert-form-submission-e2e branch from 77c5487 to 22021a9 Compare April 3, 2026 06:25
@AdityaHegde AdityaHegde force-pushed the fix/alert-form-submission-e2e branch from 22021a9 to a6f5de3 Compare April 3, 2026 12:47
@AdityaHegde AdityaHegde requested a review from djbarnwal April 6, 2026 03:48
@AdityaHegde AdityaHegde marked this pull request as ready for review April 6, 2026 10:11
@AdityaHegde AdityaHegde merged commit 68b313d into main Apr 6, 2026
23 of 27 checks passed
@AdityaHegde AdityaHegde deleted the fix/alert-form-submission-e2e branch April 6, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants