Skip to content

Comments

chore: pkg pr new bump#4257

Draft
abcxff wants to merge 1 commit intomainfrom
02-22-chore_pkg_pr_new_bump
Draft

chore: pkg pr new bump#4257
abcxff wants to merge 1 commit intomainfrom
02-22-chore_pkg_pr_new_bump

Conversation

@abcxff
Copy link
Contributor

@abcxff abcxff commented Feb 22, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Feb 22, 2026

🚅 Deployed to the rivet-pr-4257 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 22, 2026 at 3:41 pm
mcp-hub ✅ Success (View Logs) Web Feb 22, 2026 at 3:32 pm
frontend-cloud ❌ Build Failed (View Logs) Web Feb 22, 2026 at 3:32 pm
frontend-inspector ❌ Build Failed (View Logs) Web Feb 22, 2026 at 3:32 pm
ladle ❌ Build Failed (View Logs) Web Feb 22, 2026 at 3:32 pm

Copy link
Contributor Author

abcxff commented Feb 22, 2026


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 22, 2026

PR Review: chore: pkg pr new bump

This PR cleans up CI configuration and the lockfile after two packages were removed (rivetkit-typescript/packages/db and frontend/packages/example-registry). The db functionality has been folded into rivetkit as a subpath export (rivetkit/db).

Summary of Changes

  • Removes '!@rivetkit/example-registry' exclusion from turbo build in the CI workflow (correct, package no longer exists)
  • Cleans pnpm lockfile of deleted packages and their now-unused transitive dependencies

Issues Found

1. Dangling workspace resolution in root package.json

package.json still contains this entry in the resolutions block:

"@rivetkit/db": "workspace:*"

The rivetkit-typescript/packages/db directory no longer exists, making this a dangling reference. This should be removed.

2. Stale turbo build dependency in examples/sqlite-drizzle/turbo.json

{
  "tasks": {
    "build": {
      "dependsOn": ["@rivetkit/db#build", "rivetkit#build"]
    }
  }
}

@rivetkit/db#build references a package that no longer exists. The example's source already uses the new rivetkit/db subpath import (the old import is even commented out in examples/sqlite-drizzle/src/actors.ts), so the turbo dependency should be updated to just ["rivetkit#build"].

3. Leftover directory without package.json

frontend/packages/example-registry/src/_gen.ts remains in the repo but has no package.json (the directory isn't in pnpm-workspace.yaml either). This orphaned file should be removed to avoid confusion.

Correctness of Lockfile Changes

The lockfile cleanup looks accurate — all removed snapshot entries (@puppeteer/browsers, tar-fs@3.1.1, streamx, basic-ftp, etc.) are transitive dependencies that were only pulled in by the now-deleted packages. The prebuild-install deprecation notice addition is a normal lockfile update.

Minor

The PR description is a template placeholder. A brief note explaining which packages were removed and why would make this easier to understand in the future.

@abcxff abcxff force-pushed the 02-22-chore_pkg_pr_new_bump branch from 7ab0def to c73407b Compare February 22, 2026 15:34
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4257 February 22, 2026 15:34 Destroyed
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 22, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4257

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4257

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4257

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4257

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4257

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4257

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4257

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4257

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4257

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4257

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4257

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4257

commit: c73407b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant