Skip to content

Fix URL parsing to include delimiters before slashes#100

Merged
robinst merged 2 commits intorobinst:mainfrom
mre:trim-exclamation-mark
Apr 12, 2026
Merged

Fix URL parsing to include delimiters before slashes#100
robinst merged 2 commits intorobinst:mainfrom
mre:trim-exclamation-mark

Conversation

@mre
Copy link
Copy Markdown
Contributor

@mre mre commented Apr 4, 2026

A slash can be the end of a URL if the previous character is a valid URL character. This means that delimiters like ! or . before a / are included in the URL, e.g. /!/, but non-URL characters (like non-ASCII when IRI parsing is disabled) before a / are not.

Fixes #90

Add tests for URLs with delimiters followed by slashes, addressing
issue robinst#90.
@robinst robinst merged commit ad716ce into robinst:main Apr 12, 2026
7 checks passed
@robinst
Copy link
Copy Markdown
Owner

robinst commented Apr 12, 2026

Awesome, thank you!

@mre mre deleted the trim-exclamation-mark branch April 25, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trimming of exclamation mark

2 participants