add hook for setup script

[binford2k]

This gives you the ability to pass script text to the setup-ruby action. The script will be executed after Ruby and Bundler are installed, but before bundle install is run.

This lets you install packages or Bundler plugins, download patches, anything.

If you want to execute a script on disk, just pass the filename, like './setup.sh' or 'ruby setup.rb'

If you intend to use this to install a custom Bundler version or the like, make sure to specify bundler: none so you don't get a second version installed.

[eregon]

See #239 (comment)

[binford2k]

The arguments in that thread don't really hold water, imho.

If you want to run a specific shell, then you can do so with e.g. bash -c '...'. If you want to do strange things like pipes and redirects and whatnot, then you put them in a shell script, as already discussed. Declare the convention that this will fail fast and the first command that fails returns non-zero and then there's no ambiguity.

I agree that the marginally better solution would be to separate this into two actions, but that's a lot of work to do and a lot of work to migrate users to.

There are use cases for injecting commands prior to bundle install, evidenced by the fact that it keeps coming up. My own immediate use case is that I need to run bundle plugin install commands* prior to bundle install and there's no good way to do that without giving up most of the benefit of using this action to begin with. Moreover, if Bundler plugins are improved and become more common in the ecosystem like the Bundler team seems to have indicated, then this kind of use case will just become more common.

There are plenty of other use cases though, like setting up a build/install environment more complex than setup-ruby-pkgs can handle or such. Adding a simple hook here multiplies the usefulness of this awesome action with only a very small increase in complexity.

• no, I can't just add them to the Gemfile. That would defeat the purpose of being able to test Puppet modules unmodified. It would also be immensely more fragile to automate.

[eregon]

If you want to run a specific shell, then you can do so with e.g. bash -c '...'. If you want to do strange things like pipes and redirects and whatnot, then you put them in a shell script, as already discussed. Declare the convention that this will fail fast and the first command that fails returns non-zero and then there's no ambiguity.

That will still misbehave for several cases, including shell heredocs, line continuations with \, &&, etc.

Regarding the shell, maybe some people want the same as the default shell per platform, and some want Bash on all platforms. And it seems clear nobody wants to write bash -c '...' or the powershell variant, it would quickly get out of hand regarding quoting.

Basically it feels like a feature that always asks for more edge cases and infinite work to keep improving it.

If you intend to use this to install a custom Bundler version or the like, make sure to specify bundler: none so you don't get a second version installed.

I don't think this would work, bundler-cache: needs to know the Bundler version.

For your use-case would this work? Can you try it?

    - uses: ruby/setup-ruby@v1
      with:
        ruby-version: '3.4'
    - run: custom commands
    - uses: ruby/setup-ruby@v1
      with:
        ruby-version: '3.4'
        bundler-cache: true