fix(ci): fix incorrect var blocking samcli-direct runs + add expected failure#439
Open
ayush-panta wants to merge 1 commit intomainfrom
Open
fix(ci): fix incorrect var blocking samcli-direct runs + add expected failure#439ayush-panta wants to merge 1 commit intomainfrom
ayush-panta wants to merge 1 commit intomainfrom
Conversation
sondavidb
previously approved these changes
Apr 14, 2026
coderbirju
previously approved these changes
Apr 14, 2026
… failure Signed-off-by: ayush-panta <ayushkp@amazon.com>
ayush-panta
force-pushed
the
fix-samcli-test
branch
from
52b1265 to
c10781c
Compare
ayush-panta
changed the title
sondavidb
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: samcli-direct was being skipped on PR/nightly runs. The
set-varsjob correctly computeshas_creds, but the job outputs block referencedsteps.set-varsinstead of the actual step IDsteps.vars, so the value was never propagated to downstream jobs. This causedsamcli-direct-testandcleanupto always be skipped.Also adding the
test_invoke_returns_expected_results_from_git_functioncase to expected failures. The test itself passes, but it does not properly extract the expected line from progressbar, then throws a failure.License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.