fix: prevent modifier shortcut freeze during rapid CJKV switching#93
Open
darknos wants to merge 1 commit intorunjuu:mainfrom
Open
fix: prevent modifier shortcut freeze during rapid CJKV switching#93darknos wants to merge 1 commit intorunjuu:mainfrom
darknos wants to merge 1 commit intorunjuu:mainfrom
Conversation
Synthetic CGEvents posted by InputSourceSwitcher during CJKV fix (Cmd key bounce) were feeding back into ShortcutTriggerManager, corrupting pressedModifiers state and polluting lastKeyDownTimestamps. This caused subsequent modifier shortcut triggers to be permanently suppressed when rapidly alternating between left/right modifier keys. Three fixes: - Filter own-process events in CGEvent tap via PID check - During CJKV synthetic window: process flagsChanged normally to keep pressedModifiers in sync, but suppress trigger firing and combo invalidation from phantom modifiers - Evict stale lastKeyDownTimestamps entries to prevent unbounded growth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synthetic CGEvents posted by InputSourceSwitcher during CJKV fix (Cmd key bounce) were feeding back into ShortcutTriggerManager, corrupting pressedModifiers state and polluting lastKeyDownTimestamps. This caused subsequent modifier shortcut triggers to be permanently suppressed when rapidly alternating between left/right modifier keys.
Three fixes: