Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to how device information and illustrations are handled in the UI, particularly for Google Pixel devices, and refines the pull-to-refresh experience in the
SetupFeaturescomposable. The changes focus on making device illustration logic more robust, improving animation and state handling for the refresh interaction, and updating fallback behaviors for device images and logos.Device illustration and image handling (most important):
DeviceHeroCardif the device is a Pixel and a matching vector resource exists; otherwise, fallback to GSM Arena images. The fallback value for missing illustrations and Android logos is now0instead of a default drawable, ensuring no placeholder is shown when an illustration is unavailable. (DeviceHeroCard.kt,DeviceImageMapper.kt) [1] [2] [3] [4]YourAndroidActivity.kt)Pull-to-refresh and UI animation improvements:
SetupFeaturesto userememberSaveableand a coroutine scope, and added a lifecycle observer to reset the refreshing state after returning from the device details activity. (SetupFeatures.kt) [1] [2]SetupFeatures.kt) [1] [2] [3] [4]Minor cleanups and fallback changes:
DeviceHeroCard.kt)DeviceUtils.kt)