Skip to content

Develop - Your android minor improvements#258

Merged
sameerasw merged 6 commits intomainfrom
develop
Mar 2, 2026
Merged

Develop - Your android minor improvements#258
sameerasw merged 6 commits intomainfrom
develop

Conversation

@sameerasw
Copy link
Owner

This pull request introduces several improvements to how device information and illustrations are handled in the UI, particularly for Google Pixel devices, and refines the pull-to-refresh experience in the SetupFeatures composable. The changes focus on making device illustration logic more robust, improving animation and state handling for the refresh interaction, and updating fallback behaviors for device images and logos.

Device illustration and image handling (most important):

  • Only show stylized Pixel device illustrations in DeviceHeroCard if the device is a Pixel and a matching vector resource exists; otherwise, fallback to GSM Arena images. The fallback value for missing illustrations and Android logos is now 0 instead of a default drawable, ensuring no placeholder is shown when an illustration is unavailable. (DeviceHeroCard.kt, DeviceImageMapper.kt) [1] [2] [3] [4]
  • Improved logic for generating device spec search queries by prioritizing manufacturer, model, device name, and codename, allowing for more accurate GSMArena lookups. (YourAndroidActivity.kt)

Pull-to-refresh and UI animation improvements:

  • Refactored the refresh state in SetupFeatures to use rememberSaveable and a coroutine scope, and added a lifecycle observer to reset the refreshing state after returning from the device details activity. (SetupFeatures.kt) [1] [2]
  • Enhanced the pull-to-refresh card expansion and chevron animation, including animated font weight and text scaling for the device name, and improved handling of status bar padding. (SetupFeatures.kt) [1] [2] [3] [4]

Minor cleanups and fallback changes:

  • Removed beta/canary build tag indicators from the device hero card UI. (DeviceHeroCard.kt)
  • Updated device build info lookup to remove fallback to beta details from prefix, relying solely on direct lookup. (DeviceUtils.kt)

@sameerasw sameerasw self-assigned this Mar 2, 2026
@sameerasw sameerasw added the enhancement New feature or request label Mar 2, 2026
@sameerasw sameerasw merged commit 112d79f into main Mar 2, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Essentials Progress Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant