Ptfe 3083 upgrade docker images#211
Merged
matthiasL-scality merged 3 commits intomainfrom Mar 16, 2026
Merged
Conversation
8e4e45a to
f0112d8
Compare
bertranddemiddelaer
approved these changes
Mar 13, 2026
Contributor
bertranddemiddelaer
left a comment
There was a problem hiding this comment.
LGTM
(and nice work, btw !)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build and configuration to use the OpenResty 1.29.2.1 Alpine image instead of a custom Ubuntu/nginx/LuaJIT build, and makes several related compatibility and performance improvements. The changes modernize the Docker setup, simplify dependencies, and address compatibility issues with LuaJIT 5.2 semantics in OpenResty. Additionally, it improves connection handling and fixes potential deadlocks in GitHub API proxying.
Docker and Build System Modernization:
Dockerfilefromubuntu:xenialwith a custom nginx/LuaJIT build toopenresty/openresty:1.29.2.1-alpine-fat, greatly simplifying the build process and leveraging a maintained OpenResty distribution.luajitbinary path.start.sh,stop.sh) and configuration paths work unchanged with the new OpenResty layout.ngx_http_xslt_filter_moduledynamically in the nginx configuration, as required by the OpenResty Alpine image.Performance and Connection Handling Improvements:
nginx.conf.templateto improve throughput and resource utilization. [1] [2] [3]worker_processestoautoand updates the PID file location for better compatibility and scalability.Lua Compatibility and Bug Fixes:
github_access.luato correctly interpretos.executereturn values under LuaJIT with Lua 5.2 semantics (used by OpenResty), preventing cache lock logic from always failing.Other Functional Changes:
compute_aws_s3_signature.lua, allowing for longer-lived presigned URLs.