Use redirect instead of download to use s3#212
Merged
matthiasL-scality merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
8521df8 to
b8e0597
Compare
Contributor
|
This one sounds like a good idea, but it will not be fully transparent for some GET implementations which do not support location header by default. Curl will need a '-L' for example. This may require a wrapper or an alias to add a '-L' in a transparent way for our beloved CI customers. The other option is to let them fix all their workflows and calls inside their scripts. |
bertranddemiddelaer
requested changes
Mar 13, 2026
8025638 to
a31d4a4
Compare
a31d4a4 to
09b9f71
Compare
bertranddemiddelaer
approved these changes
Mar 17, 2026
Contributor
bertranddemiddelaer
left a comment
There was a problem hiding this comment.
LGTM
Beware of those changes however, they will break any CI workflow with artifacts curl calls without '-L'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the NGINX configuration to improve how file downloads from the
/builds/path are handled, providing better support for both CLI and browser clients. The main change is the introduction of logic to distinguish between CLI tools and browsers, optimizing download behavior and maintaining compatibility for directory listings and metadata requests.Improvements to download handling:
curl,wget,aria2c) to/redirect/, so they receive a presigned S3 URL and download files directly, while browser clients continue to be proxied through NGINX via/download/./download/path, preserving the original behavior for browsers.HEADrequests so that these metadata checks are always proxied directly to/download/, regardless of client type.