(PTFE-3070) Add multi part upload for artifact#214
Draft
matthiasL-scality wants to merge 2 commits intomainfrom
Draft
(PTFE-3070) Add multi part upload for artifact#214matthiasL-scality wants to merge 2 commits intomainfrom
matthiasL-scality wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces multipart upload support for artifacts, allowing large files to be uploaded in multiple parts to S3, and adds end-to-end tests for these new endpoints. The changes span Nginx configuration, Lua signature computation logic, access restrictions, and comprehensive test coverage.
Multipart upload feature additions:
Added four new Nginx locations in
nginx.conf.templateto handle multipart upload lifecycle: initiate, upload part, complete, and abort. Each endpoint proxies requests to S3 with proper validation and signature computation.Updated the Lua S3 signature computation logic to support multipart operations, including explicit resource canonicalization for each multipart endpoint and signature mode handling. [1] [2] [3]
Access control updates:
github_access.luato include/upload-multipart/, ensuring proper access control for the new endpoints.Testing improvements:
test_multipart_upload.pycovering multipart upload scenarios: single-part, multi-part, abort, out-of-order part uploads, and validation for non-staging builds.