Improvement/CLDSRV-825 drop ceph support#6097
Improvement/CLDSRV-825 drop ceph support#6097benzekrimaha wants to merge 4 commits intodevelopment/9.3from
Conversation
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
4365d2c to
178412f
Compare
tests/functional/aws-node-sdk/test/multipleBackend/objectCopy/objectCopy.js
Outdated
Show resolved
Hide resolved
tests/functional/aws-node-sdk/test/multipleBackend/objectCopy/objectCopyAwsVersioning.js
Outdated
Show resolved
Hide resolved
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
b15a533 to
a4528f1
Compare
This commit drops Ceph CI artifacts and location config, removes Ceph-specific runtime defaults, and updates reported capability flags and related unit coverage to match supported backends. Issue: CLDSRV-825
a4528f1 to
ef671c1
Compare
|
LGTM |
This commit remove Ceph-specific skip logic and behavior branches from multiple-backend/functional suites, and cleans stale Ceph comments in test files. Issue: CLDSRV-825
DarkIsDude
left a comment
There was a problem hiding this comment.
Can you check the CI 🙏 ?
c95c11c to
0390b29
Compare
|
LGTM |
0390b29 to
a79a3c6
Compare
|
LGTM |
…ties fixing tests after re enabling them
| describeSkipIfNotMultipleOrCeph('backbeat DELETE routes', () => { | ||
| it('abort MPU', done => { | ||
| describeSkipIfNotMultiple('backbeat DELETE routes', () => { | ||
| itIfLocationAws('abort MPU', done => { |
There was a problem hiding this comment.
The backbeat DELETE routes block was changed from describeSkipIfNotMultipleOrCeph (always describe.skip) to describeSkipIfNotMultiple, and the inner test was changed from plain it to itIfLocationAws. This is correct -- the abort MPU test needs the AWS location. However, this block was previously always skipped unconditionally. Now it will run when config.backends.data === 'multiple' AND the AWS location is configured. Verify CI has the AWS location available when running with the multiple backend, or this test will fail instead of being skipped.
— Claude Code
| types.filter(t => t !== cephRadosGw) | ||
| ); | ||
| } | ||
| this.capabilities = config.capabilities; |
There was a problem hiding this comment.
config.capabilities is stored as-is (unfiltered) while this.supportedLocationTypes is filtered to exclude location-ceph-radosgw-s3-v1. If any downstream code reads this.capabilities.locationTypes directly instead of this.supportedLocationTypes, the Ceph entry would still be visible. Currently reportHandler.js uses supportedLocationTypes so this works, but for consistency consider filtering config.capabilities.locationTypes before storing, or adding a note that this.capabilities is the raw config.
— Claude Code
|
LGTM with minor notes: |
DarkIsDude
left a comment
There was a problem hiding this comment.
I found some CEPH reference in the product doc that we should also clean. The CI is still unstable
| caps.locationTypeDigitalOcean &&= cfg.supportedLocationTypes.has('location-do-spaces-v1'); | ||
| caps.locationTypeSproxyd &&= cfg.supportedLocationTypes.has('location-scality-sproxyd-v1'); | ||
| caps.locationTypeNFS &&= cfg.supportedLocationTypes.has('location-nfs-mount-v1'); | ||
| caps.locationTypeCephRadosGW &&= cfg.supportedLocationTypes.has('location-ceph-radosgw-s3-v1'); |
There was a problem hiding this comment.
I'm not sure to understand your point @francoisferrand
Issue: CLDSRV-825