Skip to content

impr(CLDSRV-852): Refactor cache and helpers#6107

Open
tmacro wants to merge 2 commits intoimprovement/CLDSRV-869/account_limitingfrom
improvement/CLDSRV-852/refactor_cache
Open

impr(CLDSRV-852): Refactor cache and helpers#6107
tmacro wants to merge 2 commits intoimprovement/CLDSRV-869/account_limitingfrom
improvement/CLDSRV-852/refactor_cache

Conversation

@tmacro
Copy link
Contributor

@tmacro tmacro commented Mar 13, 2026

  • Refactors the cache mechanism to allow for namespaced keys
  • Refactors the helper function to split the responsibility of extract the configuration and storing it in the cache.
  • Updates tests to match new structure.

Note for revewers: This PR "breaks" most of the S3 API unit tests as metadataUtils.js is still using the old helpers. Fixes will come in later feature branch PRs.

claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 13, 2026 •
edited
Loading

❌ 109 Tests Failed:

Tests completed Failed Passed Skipped
2695 109 2586 0
View the top 3 failed test(s) by shortest run time 
should be successful initiating MPU on AWS with Scality S3 versioning enabled::Multipart Upload API with AWS Backend should be successful initiating MPU on AWS with Scality S3 versioning enabled
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should complete a multipart upload on real AWS location with bucketMatch set to false::Multipart Upload API with AWS Backend should complete a multipart upload on real AWS location with bucketMatch set to false
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should complete a multipart upload on real AWS::Multipart Upload API with AWS Backend should complete a multipart upload on real AWS
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should copy part an object on AWS location that has bucketMatch equals false to a mpu with a different AWS location::ObjectCopyPutPart API with multiple backends should copy part an object on AWS location that has bucketMatch equals false to a mpu with a different AWS location
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should copy part to AWS based on bucket location::ObjectCopyPutPart API with multiple backends should copy part to AWS based on bucket location
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should initiate a multipart upload on AWS location with bucketMatch equals false::Multipart Upload API with AWS Backend should initiate a multipart upload on AWS location with bucketMatch equals false
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should initiate a multipart upload with tags on AWS::Multipart Upload API with AWS Backend should initiate a multipart upload with tags on AWS
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should list all multipart uploads on all backends::Multipart Upload API with AWS Backend should list all multipart uploads on all backends
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should list multipart upload parts::Multipart Upload API with AWS Backend with mpu initiated on legacy version should list multipart upload parts
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should list the parts of a multipart upload on real AWS location with bucketMatch set to false::Multipart Upload API with AWS Backend should list the parts of a multipart upload on real AWS location with bucketMatch set to false
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should list the parts of a multipart upload on real AWS::Multipart Upload API with AWS Backend should list the parts of a multipart upload on real AWS
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should only list parts after PartNumberMarker::Multipart Upload API with AWS Backend should only list parts after PartNumberMarker
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should only return number of parts equal to specified maxParts::Multipart Upload API with AWS Backend should only return number of parts equal to specified maxParts
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should put a part to AWS based on bucket location with bucketMatch set to false::objectPutPart API with multiple backends should put a part to AWS based on bucket location with bucketMatch set to false
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should put a part to AWS based on bucket location with bucketMatch set to true::objectPutPart API with multiple backends should put a part to AWS based on bucket location with bucketMatch set to true
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should put a part to AWS based on bucket location::objectPutPart API with multiple backends should put a part to AWS based on bucket location
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should put a part to AWS based on mpu location::objectPutPart API with multiple backends should put a part to AWS based on mpu location
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should put a part to mem based on bucket location::objectPutPart API with multiple backends should put a part to mem based on bucket location
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should put an object to Azure based on bucket location::objectPutAPI with multiple backends should put an object to Azure based on bucket location
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should put an object to sproxyd::objectPutAPI with multiple backends should put an object to sproxyd
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should put an object to us-east-1 which is file based on bucket location if no locationConstraint provided::objectPutAPI with multiple backends should put an object to us-east-1 which is file based on bucket location if no locationConstraint provided
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should replace part if two parts uploaded with same part number to AWS::objectPutPart API with multiple backends should replace part if two parts uploaded with same part number to AWS
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should return ServiceUnavailable if MPU deleted directly from AWS and try to complete from S3::Multipart Upload API with AWS Backend should return ServiceUnavailable if MPU deleted directly from AWS and try to complete from S3
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should return an error on listParts of deleted MPU::Multipart Upload API with AWS Backend should return an error on listParts of deleted MPU
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should return entityTooSmall error::Multipart Upload API with AWS Backend should return entityTooSmall error
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should return error on abort of MPU that does not exist::Multipart Upload API with AWS Backend should return error on abort of MPU that does not exist
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should return invalidPart error::Multipart Upload API with AWS Backend should return invalidPart error
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should return invalidPartOrder error::Multipart Upload API with AWS Backend should return invalidPartOrder error
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
should store a part even if the MPU was initiated on legacy version::objectPutPart API with multiple backends should store a part even if the MPU was initiated on legacy version
Stack Traces | 0s run time 
extractAndCacheRateLimitConfig is not a function
"after all" hook for "PUT .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/capacity.xml should fail if invalid credentials are sent"::Veeam routes: veeam PUT routes: "after all" hook for "PUT .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/capacity.xml should fail if invalid credentials are sent"
Stack Traces | 0.001s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
"after each" hook for "DELETE .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should delete the XML file"::Veeam routes: veeam DELETE routes: "after each" hook for "DELETE .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should delete the XML file"
Stack Traces | 0.001s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
"after each" hook for "GET .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should return the expected XML file"::Veeam routes: veeam GET routes: "after each" hook for "GET .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should return the expected XML file"
Stack Traces | 0.001s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
"after each" hook for "HEAD .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should return the existing XML file metadata"::Veeam routes: veeam HEAD routes: "after each" hook for "HEAD .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should return the existing XML file metadata"
Stack Traces | 0.001s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
"after each" hook for "should successfully replicate a version"::backbeat routes for replication (same account) "after each" hook for "should successfully replicate a version"
Stack Traces | 0.001s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
"before each" hook for "should successfully replicate a version"::backbeat routes for replication (cross account) "before each" hook for "should successfully replicate a version"
Stack Traces | 0.001s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
"before each" hook for "should successfully replicate a version"::backbeat routes for replication (same account) "before each" hook for "should successfully replicate a version"
Stack Traces | 0.001s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should abort a multipart upload on real AWS location withbucketMatch set to false::Multipart Upload API with AWS Backend should abort a multipart upload on real AWS location withbucketMatch set to false
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should abort a multipart upload on real AWS::Multipart Upload API with AWS Backend should abort a multipart upload on real AWS
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should abort a multipart upload::Multipart Upload API with AWS Backend with mpu initiated on legacy version should abort a multipart upload
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should allow a restore if the quota is full but the objet fits with its reserved storage space::quota evaluation with scuba metrics should allow a restore if the quota is full but the objet fits with its reserved storage space
Stack Traces | 0.001s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should allow creating mpu with SSE header in encrypted bucket::KMIP backed server-side encryption should allow creating mpu with SSE header in encrypted bucket
Stack Traces | 0.001s run time 
connect ECONNREFUSED 127.0.0.1:8000
should allow object copy with SSE header in encrypted bucket::KMIP backed server-side encryption should allow object copy with SSE header in encrypted bucket
Stack Traces | 0.001s run time 
connect ECONNREFUSED 127.0.0.1:8000
should complete MPU on AWS with same key as object put to file::Multipart Upload API with AWS Backend should complete MPU on AWS with same key as object put to file
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should complete MPU on file with same key as object put to AWS::Multipart Upload API with AWS Backend should complete MPU on file with same key as object put to AWS
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should complete a multipart upload::Multipart Upload API with AWS Backend with mpu initiated on legacy version should complete a multipart upload
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should copy an object as a part to a multipart upload::Multipart Upload API with AWS Backend with mpu initiated on legacy version should copy an object as a part to a multipart upload
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should copy part an object on AWS to a mpu with a different AWS location that has bucketMatch equals false::ObjectCopyPutPart API with multiple backends should copy part an object on AWS to a mpu with a different AWS location that has bucketMatch equals false
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should copy part to AWS based on mpu location::ObjectCopyPutPart API with multiple backends should copy part to AWS based on mpu location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should copy part to file based on bucket location::ObjectCopyPutPart API with multiple backends should copy part to file based on bucket location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should copy part to file based on mpu location::ObjectCopyPutPart API with multiple backends should copy part to file based on mpu location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should copy part to file based on request endpoint::ObjectCopyPutPart API with multiple backends should copy part to file based on request endpoint
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should copy part to mem based on bucket location::ObjectCopyPutPart API with multiple backends should copy part to mem based on bucket location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should copy part to mem based on mpu location::ObjectCopyPutPart API with multiple backends should copy part to mem based on mpu location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should copy part to mem from AWS based on mpu location::ObjectCopyPutPart API with multiple backends should copy part to mem from AWS based on mpu location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should decrease the inflights when performing multi object delete::quota evaluation with scuba metrics should decrease the inflights when performing multi object delete
Stack Traces | 0.001s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should not increase the inflights when the object is being rewritten with a smaller object::quota evaluation with scuba metrics should not increase the inflights when the object is being rewritten with a smaller object
Stack Traces | 0.001s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should not update the inflights if the API errored after evaluating quotas (deletion)::quota evaluation with scuba metrics should not update the inflights if the API errored after evaluating quotas (deletion)
Stack Traces | 0.001s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should only evaluate quota and not update inflights for PutObject with the x-scal-s3-version-id header::quota evaluation with scuba metrics should only evaluate quota and not update inflights for PutObject with the x-scal-s3-version-id header
Stack Traces | 0.001s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should put a part to file based on bucket location::objectPutPart API with multiple backends should put a part to file based on bucket location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should put a part to file based on request endpoint::objectPutPart API with multiple backends should put a part to file based on request endpoint
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should put a part to mem based on mpu location::objectPutPart API with multiple backends should put a part to mem based on mpu location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should put an object to AWS based on bucket location::objectPutAPI with multiple backends should put an object to AWS based on bucket location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should put an object to AWS::objectPutAPI with multiple backends should put an object to AWS
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should put an object to azure::objectPutAPI with multiple backends should put an object to azure
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should put an object to file based on bucket location::objectPutAPI with multiple backends should put an object to file based on bucket location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should put an object to file::objectPutAPI with multiple backends should put an object to file
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should put an object to mem based on bucket location::objectPutAPI with multiple backends should put an object to mem based on bucket location
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
should reduce inflights when completing MPU with fewer parts than uploaded::quota evaluation with scuba metrics should reduce inflights when completing MPU with fewer parts than uploaded
Stack Traces | 0.001s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should return QuotaExceeded when trying to complete MPU in a bucket with quota::quota evaluation with scuba metrics should return QuotaExceeded when trying to complete MPU in a bucket with quota
Stack Traces | 0.001s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should upload part based on mpu location even if part location constraint is specified ::objectPutPart API with multiple backends should upload part based on mpu location even if part location constraint is specified
Stack Traces | 0.001s run time 
extractAndCacheRateLimitConfig is not a function
"after each" hook for "should successfully replicate a version"::backbeat routes for replication (cross account) "after each" hook for "should successfully replicate a version"
Stack Traces | 0.002s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
"before all" hook for "PUT .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml"::Veeam routes: veeam PUT routes: "before all" hook for "PUT .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml"
Stack Traces | 0.002s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
"before each" hook for "DELETE .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should delete the XML file"::Veeam routes: veeam DELETE routes: "before each" hook for "DELETE .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should delete the XML file"
Stack Traces | 0.002s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
"before each" hook for "GET .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should return the expected XML file"::Veeam routes: veeam GET routes: "before each" hook for "GET .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should return the expected XML file"
Stack Traces | 0.002s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
"before each" hook for "HEAD .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should return the existing XML file metadata"::Veeam routes: veeam HEAD routes: "before each" hook for "HEAD .system-d26a9498-cb7c-4a87-a44a-8ae204f5ba6c/system.xml should return the existing XML file metadata"
Stack Traces | 0.002s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should allow object PUT with SSE header in encrypted bucket::KMIP backed server-side encryption should allow object PUT with SSE header in encrypted bucket
Stack Traces | 0.002s run time 
connect ECONNREFUSED 127.0.0.1:8000
should allow writes after multi-deleting data with quotas below the current number of inflights::quota evaluation with scuba metrics should allow writes after multi-deleting data with quotas below the current number of inflights
Stack Traces | 0.002s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should initiate a multipart upload on real AWS::Multipart Upload API with AWS Backend should initiate a multipart upload on real AWS
Stack Traces | 0.002s run time 
extractAndCacheRateLimitConfig is not a function
should not evaluate quotas if the backend is not available::quota evaluation with scuba metrics should not evaluate quotas if the backend is not available
Stack Traces | 0.002s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should not return QuotaExceeded if the quota is not exceeded::quota evaluation with scuba metrics should not return QuotaExceeded if the quota is not exceeded
Stack Traces | 0.002s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should put an object to mem::objectPutAPI with multiple backends should put an object to mem
Stack Traces | 0.002s run time 
extractAndCacheRateLimitConfig is not a function
should reduce inflights when aborting MPU::quota evaluation with scuba metrics should reduce inflights when aborting MPU
Stack Traces | 0.002s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should return QuotaExceeded when trying to CopyObject in a bucket with quota::quota evaluation with scuba metrics should return QuotaExceeded when trying to CopyObject in a bucket with quota
Stack Traces | 0.002s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should return QuotaExceeded when trying to copy a part in a bucket with quota::quota evaluation with scuba metrics should return QuotaExceeded when trying to copy a part in a bucket with quota
Stack Traces | 0.002s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should return QuotaExceeded when trying to copyObject in a versioned bucket with quota::quota evaluation with scuba metrics should return QuotaExceeded when trying to copyObject in a versioned bucket with quota
Stack Traces | 0.002s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should return QuotaExceeded when trying to restore an object in a bucket with quota::quota evaluation with scuba metrics should return QuotaExceeded when trying to restore an object in a bucket with quota
Stack Traces | 0.002s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should upload a part to file based on mpu location::objectPutPart API with multiple backends should upload a part to file based on mpu location
Stack Traces | 0.002s run time 
extractAndCacheRateLimitConfig is not a function
object metadata for newly stored object should have dataStoreName if copying to mem based on bucket location::ObjectCopy API with multiple backends object metadata for newly stored object should have dataStoreName if copying to mem based on bucket location
Stack Traces | 0.003s run time 
extractAndCacheRateLimitConfig is not a function
should allow writes after deleting data with quotas::quota evaluation with scuba metrics should allow writes after deleting data with quotas
Stack Traces | 0.003s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should create an encrypted bucket and upload an object::KMIP backed server-side encryption should create an encrypted bucket and upload an object
Stack Traces | 0.003s run time 
connect ECONNREFUSED 127.0.0.1:8000
should not update the inflights if the quota check is passing but the object is already restored::quota evaluation with scuba metrics should not update the inflights if the quota check is passing but the object is already restored
Stack Traces | 0.004s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should allow writes after deleting data with quotas below the current number of inflights::quota evaluation with scuba metrics should allow writes after deleting data with quotas below the current number of inflights
Stack Traces | 0.006s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should return MethodNotAllowed for invalid request::Veeam routes: veeam invalid requests: should return MethodNotAllowed for invalid request
Stack Traces | 0.01s run time 
Cannot read properties of undefined (reading 'statusCode')
"after all" hook in "backbeat routes"::backbeat routes "after all" hook in "backbeat routes"
Stack Traces | 0.014s run time 
Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should return QuotaExceeded when trying to PutObject in a bucket with quota::quota evaluation with scuba metrics should return QuotaExceeded when trying to PutObject in a bucket with quota
Stack Traces | 0.085s run time 
ifError got unwanted exception: socket hang up
should create an encrypted bucket::KMIP backed server-side encryption should create an encrypted bucket
Stack Traces | 0.089s run time 
socket hang up
"before all" hook in "backbeat routes"::backbeat routes "before all" hook in "backbeat routes"
Stack Traces | 0.139s run time 
read ECONNRESET
should set metrics for multipartUpload in a versioned bucket::utapi v2 metrics incoming and outgoing bytes should set metrics for multipartUpload in a versioned bucket
Stack Traces | 0.141s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should not push a metric for a filtered bucket::utapi v2 metrics incoming and outgoing bytes should not push a metric for a filtered bucket
Stack Traces | 0.145s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should set metrics for multiPartUpload overwrite::utapi v2 metrics incoming and outgoing bytes should set metrics for multiPartUpload overwrite
Stack Traces | 0.186s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should set metrics for copyObject::utapi v2 metrics incoming and outgoing bytes should set metrics for copyObject
Stack Traces | 0.208s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should set metrics for multiObjectDelete in a versioned bucket::utapi v2 metrics incoming and outgoing bytes should set metrics for multiObjectDelete in a versioned bucket
Stack Traces | 0.232s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should set metrics for getObject::utapi v2 metrics incoming and outgoing bytes should set metrics for getObject
Stack Traces | 0.33s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should set metrics for putObject and deleteObject::utapi v2 metrics incoming and outgoing bytes should set metrics for putObject and deleteObject
Stack Traces | 0.354s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should set metrics for createBucket and deleteBucket::utapi v2 metrics incoming and outgoing bytes should set metrics for createBucket and deleteBucket
Stack Traces | 0.397s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should set metrics for multipartUpload overwrite in a versioned bucket::utapi v2 metrics incoming and outgoing bytes should set metrics for multipartUpload overwrite in a versioned bucket
Stack Traces | 0.401s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should set metrics in versioned bucket::utapi v2 metrics incoming and outgoing bytes should set metrics in versioned bucket
Stack Traces | 0.408s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should set metrics for multiObjectDelete::utapi v2 metrics incoming and outgoing bytes should set metrics for multiObjectDelete
Stack Traces | 0.513s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.
should set metrics for multiPartUpload::utapi v2 metrics incoming and outgoing bytes should set metrics for multiPartUpload
Stack Traces | 0.566s run time 
ifError got unwanted exception: Inaccessible host: `127.0.0.1' at port `8000'. This service may not be available in the `us-east-1' region.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@scality scality deleted a comment from claude bot Mar 13, 2026
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
@claude
Copy link

claude bot commented Mar 13, 2026

  • helpers.js:91 — cache.getCachedBucketOwner is called but does not exist in cache.js. Will throw TypeError at runtime.
  • helpers.js:109-128 — getTokenBucket is called with a new 5-arg signature but tokenBucket.js still has the old 3-arg signature. The returned WorkerTokenBucket also lacks resourceClass, resourceId, measure properties and the hasCapacity() method. All will fail at runtime.
  • helpers.js:124 — Log says token consumed but consumption happens later on line 132. Misleading.
  • tests/helpers.js:117 — before() creates a sandbox stub but parent afterEach calls sandbox.restore(), removing the stub after the first test. Use beforeEach instead.

Review by Claude Code

claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 13, 2026
View reviewed changes
@claude
Copy link

claude bot commented Mar 13, 2026

  • helpers.js:91 - cache.getCachedBucketOwner is not defined or exported from cache.js. Will throw TypeError at runtime.
    - helpers.js:109 - getTokenBucket signature mismatch: tokenBucket.js expects (bucketName, limitConfig, log) but this passes 5 args. Needs tokenBucket.js update or adjusted call.
    - helpers.js:110 - bucket.hasCapacity() does not exist on WorkerTokenBucket. Will always return undefined (falsy), denying every request.
    - helpers.js:124 - Log says token consumed but consumption happens later at line 132. Misleading log message.

    Review by Claude Code

@tmacro tmacro force-pushed the improvement/CLDSRV-853/account_rate_limit_config_joi branch from a09c5af to ec63d65 Compare March 18, 2026 18:33
Base automatically changed from improvement/CLDSRV-853/account_rate_limit_config_joi to improvement/CLDSRV-869/account_limiting March 18, 2026 18:35
@tmacro tmacro force-pushed the improvement/CLDSRV-852/refactor_cache branch from 4b83cef to b40ff80 Compare March 18, 2026 20:47
claude[bot]
claude bot reviewed Mar 18, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 18, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 18, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 18, 2026
View reviewed changes
claude[bot]
claude bot reviewed Mar 18, 2026
View reviewed changes
@claude
Copy link

claude bot commented Mar 18, 2026

  • helpers.js:91 — cache.getCachedBucketOwner is not defined or exported from cache.js. Runtime TypeError.
    • Define and export getCachedBucketOwner in cache.js, or remove the call if it belongs in a later PR.
  • helpers.js:109-110 — getTokenBucket is called with 5 args (resourceClass, resourceId, measure, config, log) but tokenBucket.js only accepts 3 (bucketName, limitConfig, log). Also, bucket.hasCapacity() does not exist on WorkerTokenBucket, and bucket.resourceClass/resourceId/measure are not defined properties.
    • Update WorkerTokenBucket to match the new calling convention, or keep the old signature and adapt the call site. Add hasCapacity() method or use tryConsume() for the capacity check.
  • cache.js:3-5 — namespace object only has bucket but helpers.js references cache.namespace.account, which is undefined.
    • Add account to the namespace object.
  • helpers.js:124 — Log message says token consumed before tokens are actually consumed (line 132).
    • Change message to reflect that capacity was checked, not consumed.
  • helpers.js:63-103 — extractRateLimitConfigFromRequest is added and exported but has no tests.
    • Add unit tests for this function.

Review by Claude Code

@tmacro tmacro force-pushed the improvement/CLDSRV-852/refactor_cache branch from b40ff80 to 100976b Compare March 19, 2026 15:29
claude[bot]
claude bot reviewed Mar 19, 2026
View reviewed changes
lib/api/apiUtils/rateLimit/helpers.js
}

if (!request.accountLimits) {
const cachedOwner = cache.getCachedBucketOwner(request.bucketName);
Copy link

@claude claude bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache.getCachedBucketOwner is not defined or exported from cache.js. This will throw a TypeError: cache.getCachedBucketOwner is not a function at runtime.

— Claude Code

claude[bot]
claude bot reviewed Mar 19, 2026
View reviewed changes
lib/api/apiUtils/rateLimit/helpers.js
buckets.push(bucket);

if (allowed) {
log.trace('Rate limit check: allowed (token consumed)', {
Copy link

@claude claude bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log message says "token consumed" but tokens are not consumed until line 132 (bucket.tryConsume()). At this point we only know the bucket has capacity. Consider changing the message to something like "Rate limit check: passed (has capacity)".

— Claude Code

claude[bot]
claude bot reviewed Mar 19, 2026
View reviewed changes
lib/api/apiUtils/rateLimit/cache.js
// Map<bucketKey, Array<timestamp>> - rolling 1-second window
const requestTimestamps = new Map();
const namespace = {
bucket: 'bkt',
Copy link

@claude claude bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace only defines bucket: 'bkt', but helpers.js:93 uses cache.namespace.account which is undefined. This will produce cache keys like undefined:accountId. Add account to the namespace object.

— Claude Code

claude[bot]
claude bot reviewed Mar 19, 2026
View reviewed changes
lib/api/apiUtils/rateLimit/helpers.js
function checkRateLimitsForRequest(checks, log) {
const buckets = [];
for (const check of checks) {
const bucket = getTokenBucket(check.resourceClass, check.resourceId, check.measure, check.config, log);
Copy link

@claude claude bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getTokenBucket in tokenBucket.js has signature (bucketName, limitConfig, log) (3 params), but here it is called with 5 args: (resourceClass, resourceId, measure, config, log). This means limitConfig receives a string (resourceId) and log receives a string (measure), causing runtime failures.

Also, bucket.hasCapacity() (line 110) does not exist on WorkerTokenBucket — the class only has tryConsume(). This will return undefined (falsy), causing all requests to be denied.

It looks like tokenBucket.js needs to be updated in this PR to match the new calling convention.

— Claude Code

@claude
Copy link

claude bot commented Mar 19, 2026

  • helpers.js:109-110: getTokenBucket is called with 5 args but the function in tokenBucket.js takes 3. Also bucket.hasCapacity() does not exist on WorkerTokenBucket. Both will cause runtime failures — tokenBucket.js needs to be updated in this PR.
  • helpers.js:91: cache.getCachedBucketOwner is not defined or exported from cache.js. Runtime TypeError.
  • cache.js:4: namespace only defines bucket, but helpers.js:93 references cache.namespace.account which is undefined.
  • helpers.js:124: Log says "token consumed" but consumption happens later at line 132. Misleading message.

Review by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@BourgoisMickael BourgoisMickael BourgoisMickael approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmacro @BourgoisMickael