Skip to content

Remove forward compatibility check#2395

Merged
pdrobnjak merged 1 commit intomainfrom
pd/remove-forward-compatibility-check
Sep 24, 2025
Merged

Remove forward compatibility check#2395
pdrobnjak merged 1 commit intomainfrom
pd/remove-forward-compatibility-check

Conversation

@pdrobnjak
Copy link
Copy Markdown
Contributor

@pdrobnjak pdrobnjak commented Sep 24, 2025

Describe your changes and provide context

#2377 this PR failed the forward compatibility check because of an ABI/API break, caused by changes in sei-protocol/sei-cosmos#605 more concretely codec/amino.go function renames.

The failure is not localised to #2377, the API break makes main broken from the perspective of CI/CD.

Analysis of pros and cons of this kind of compatibility check

Pro

When a Cosmos SDK version bump happens we will be compatible so the PR will most likely be a one liner dependency bump.

Con

Keeping forward compatibility works by random spilling over to the first person that creates the PR in the repo that has its forward compatibility broken.

Solution

Solution for now is to remove forward compatibility check altogether.

Correct way to check for forward compatibility would be to run this check in sei-cosmos (also it should be run for all repos dependent on sei-cosmos) so that the assignee is aware that he broke compatibility and should create subsequent PRs on dependent repos.

Testing performed to validate your change

CI run on this PR without the forward compatibility check.

@pdrobnjak pdrobnjak self-assigned this Sep 24, 2025
@pdrobnjak pdrobnjak enabled auto-merge (squash) September 24, 2025 14:50
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.42%. Comparing base (b60dd14) to head (a98ec1c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2395   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files         314      314           
  Lines       31116    31116           
=======================================
  Hits        18801    18801           
  Misses      10994    10994           
  Partials     1321     1321           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdrobnjak pdrobnjak merged commit 4b7938c into main Sep 24, 2025
70 of 76 checks passed
@pdrobnjak pdrobnjak deleted the pd/remove-forward-compatibility-check branch September 24, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants