Merged
Conversation
masih
approved these changes
Sep 24, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
=======================================
Coverage 60.42% 60.42%
=======================================
Files 314 314
Lines 31116 31116
=======================================
Hits 18801 18801
Misses 10994 10994
Partials 1321 1321 🚀 New features to boost your workflow:
|
stevenlanders
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
#2377 this PR failed the forward compatibility check because of an ABI/API break, caused by changes in sei-protocol/sei-cosmos#605 more concretely
codec/amino.gofunction renames.The failure is not localised to #2377, the API break makes main broken from the perspective of CI/CD.
Analysis of pros and cons of this kind of compatibility check
Pro
When a Cosmos SDK version bump happens we will be compatible so the PR will most likely be a one liner dependency bump.
Con
Keeping forward compatibility works by random spilling over to the first person that creates the PR in the repo that has its forward compatibility broken.
Solution
Solution for now is to remove forward compatibility check altogether.
Correct way to check for forward compatibility would be to run this check in
sei-cosmos(also it should be run for all repos dependent onsei-cosmos) so that the assignee is aware that he broke compatibility and should create subsequent PRs on dependent repos.Testing performed to validate your change
CI run on this PR without the forward compatibility check.