Fix drumkit table to only use PCM presets 0-10#661
Merged
Conversation
The PCM sample set was trimmed to 11 samples but the drumkit table still referenced presets up to 25, causing most drum notes to wrap to preset 0 (maraca). Remap all entries to use only the available presets with appropriate pitch transpositions. Mark unavailable drums (bongos, congas, etc.) as -1 for future samples. Update test reference WAVs for new drum sounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCM sample set was trimmed to 11 samples but the drumkit table still referenced presets up to 25, causing most drum notes to wrap to preset 0 (maraca).
Remap all GM drum entries to only use available presets 0-10 with appropriate pitch transpositions. Unavailable drums marked -1 for future samples.
All 79 tests pass.