Merged
Conversation
The micropython manifest switched from individual freeze() calls to
package("amy"), so piano_params is now only available as amy.piano_params,
not as a top-level module. Updated imports and rebuilt micropython.wasm.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NameError: name 'NUM_HARMONICS' isn't definedin piano.html tutorialfreeze()topackage("amy"), sopiano_paramsis now only importable asamy.piano_params, not as a top-level modulefrom piano_params import notes_params→from amy.piano_params import notes_paramsindocs/piano.htmlandamy/piano.pymicropython.wasmwith the updated frozen modulesTest plan
NUM_HARMONICSerror🤖 Generated with Claude Code