fix: improve error handling, add godoc, and fix bugs across core packages#2328
Open
diegofornalha wants to merge 1 commit intosipeed:mainfrom
Open
fix: improve error handling, add godoc, and fix bugs across core packages#2328diegofornalha wants to merge 1 commit intosipeed:mainfrom
diegofornalha wants to merge 1 commit intosipeed:mainfrom
Conversation
…ages - pkg/pid: log os.Remove errors instead of ignoring, fix Windows syscall - pkg/session: add godoc to all exported methods, handle os.MkdirAll error - pkg/logger: fix nil err in Errorf, handle logFile.Close errors, add godoc - pkg/cron: add input validation in AddJob, add godoc to all exported methods - pkg/config: log SaveConfig errors during migration, add godoc Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sipeed-bot
bot
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.Removeerrors instead of ignoring, fix Windows syscallos.MkdirAllerrorErrorf, handlelogFile.Closeerrors, add godocAddJob, add godoc to all exported methodsSaveConfigerrors during migration, add godocTest plan
go test ./pkg/...)🤖 Generated with Claude Code