Open
Conversation
Member
|
Thanks for the PR. It already is looking great and i generally like the idea of supporting kubernetes. A full review will take a bit as i have to find some time. One thing i can already say i would prefer nested configuration pathes like |
Contributor
Author
|
Sure, no problem :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We love this package (Thanks BTW!) and wanted to use it for our new Kubernetes-based hosting.
That's why I added a configuration option with Kubernetes. It only uses the Kubernetes API, so no SSH or similar needs to be used. Only the kubeconfig file needs to be available.
At the same time, I have tried to extract some of the existing code into my own methods to make them easier to reuse.
The exact configuration is explained in the README. The old config does not need to be adapted and all previous functions still work.
I would be happy if we could get a new version of the MagicWand from this.
Many thanks in advance!