Use helm chart as source of install resources#2376
Draft
c-kruse wants to merge 2 commits intoskupperproject:mainfrom
Draft
Use helm chart as source of install resources#2376c-kruse wants to merge 2 commits intoskupperproject:mainfrom
c-kruse wants to merge 2 commits intoskupperproject:mainfrom
Conversation
Adds the skupper helm chart to version control to be the primary source of Skupper controller installation resources. Replaces the skupper-deployment-generator scripts as the source of truth. Changes: - Breaking: Drops CRDs from skupper chart. - Adds new skupper-crds.yaml manifest release artifact - Adds skupper-crds helm chart - Updates skupper chart README with CRD installation instructions - Extends the skupper chart with templated values for user requested overrides: tolerations, affinity, resources, labels+annotations. - Update charts/README.md with quick start guide - Update kind-dev-cluster script to use helm install Signed-off-by: Christian Kruse <christian@c-kruse.com>
| - go/mod-download-cached | ||
| - kubectl-install | ||
| - helm-install | ||
| - run: make generate-skupper-helm-chart |
Contributor
There was a problem hiding this comment.
I think this line can get removed since the makefile command and the associated script were removed.
Contributor
|
This looks great! I tested:
These all seemed to work as expected as far as my testing and understanding went. Let me know if there are other ways I should be testing this or if there is anything else in particular I should look at. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the skupper helm chart to version control to be the primary source of Skupper controller installation resources. Replaces the skupper-deployment-generator scripts as the source of truth.
Changes:
Part of #2362 and #2306
Closes #2351