Skip to content
This repository was archived by the owner on Nov 3, 2025. It is now read-only.

Make PanModalPresentationController's methods open so they can be overriden by a subclass #181

Open
bartosz-treeline wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make PanModalPresentationController's methods open so they can be overriden by a subclass #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions PanModal/Controller/PanModalPresentationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,12 @@ open class PanModalPresentationController: UIPresentationController {

// MARK: - Lifecycle

override public func containerViewWillLayoutSubviews() {
override open func containerViewWillLayoutSubviews() {
super.containerViewWillLayoutSubviews()
configureViewLayout()
}

override public func presentationTransitionWillBegin() {
override open func presentationTransitionWillBegin() {

guard let containerView = containerView
else { return }
Expand All @@ -192,13 +192,13 @@ open class PanModalPresentationController: UIPresentationController {
})
}

override public func presentationTransitionDidEnd(_ completed: Bool) {
override open func presentationTransitionDidEnd(_ completed: Bool) {
if completed { return }

backgroundView.removeFromSuperview()
}

override public func dismissalTransitionWillBegin() {
override open func dismissalTransitionWillBegin() {
presentable?.panModalWillDismiss()

guard let coordinator = presentedViewController.transitionCoordinator else {
Expand All @@ -217,7 +217,7 @@ open class PanModalPresentationController: UIPresentationController {
})
}

override public func dismissalTransitionDidEnd(_ completed: Bool) {
override open func dismissalTransitionDidEnd(_ completed: Bool) {
if !completed { return }

presentable?.panModalDidDismiss()
Expand All @@ -226,7 +226,7 @@ open class PanModalPresentationController: UIPresentationController {
/**
Update presented view size in response to size class changes
*/
override public func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
override open func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
super.viewWillTransition(to: size, with: coordinator)

coordinator.animate(alongsideTransition: { [weak self] _ in
Expand Down