-
Notifications
You must be signed in to change notification settings - Fork 14
fix: update AI fix unavailable message [IDE-1598] #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update the message displayed when AI fixes cannot be generated to better explain the validation process and provide clearer guidance to users. The new message explains that: - Fix suggestions go through multiple validations - Generated code must be secure and error-free - Users are referred to Fix Analysis and Issue Overview for manual remediation - Documentation link is provided for more information
Summary of ChangesHello @acke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience by providing a more informative and actionable message when AI-generated code fixes are not available. The update aims to educate users on the validation process for these fixes and guide them towards alternative methods for resolving issues, thereby improving clarity and reducing potential frustration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the message displayed when an AI fix is unavailable, providing more detailed guidance to the user. The change is straightforward. I've provided one suggestion to improve the HTML structure by using paragraph tags (<p>) instead of line breaks (<br>), which enhances semantics and accessibility. I also suggested fixing the link text for the documentation.
| We attempted to generate a fix, but the suggestions did not pass validation | ||
| <br> | ||
| To ensure your code remains secure and error-free, no automatic fix suggestion will be recommended for this issue. | ||
| Each generated fix suggestion goes through multiple validations | ||
| <br> | ||
| You can review suggested areas to improve or retry once updates have been made. | ||
| to ensure the generated code is secure and error-free. In this | ||
| <br> | ||
| Read more in our | ||
| case, we were unable to generate a quality fix and must refer | ||
| <br> | ||
| you to the Fix Analysis and Issue Overview for manual | ||
| <br> | ||
| remediation of the issue. | ||
| <br> | ||
| For more information on the limitations and validations for Agent Fix, see our | ||
| <a class="styled-link" href="https://docs.snyk.io/scan-with-snyk/snyk-code/manage-code-vulnerabilities/fix-code-vulnerabilities-automatically#limitations"> | ||
| [documentation] | ||
| </a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better semantic HTML and accessibility, it's recommended to use <p> tags for paragraphs instead of using multiple <br> tags for line breaks. This also makes the content easier to style and maintain.
Additionally, the link text [documentation] appears to be a remnant of markdown syntax and should be updated to just documentation for proper HTML.
| We attempted to generate a fix, but the suggestions did not pass validation | |
| <br> | |
| To ensure your code remains secure and error-free, no automatic fix suggestion will be recommended for this issue. | |
| Each generated fix suggestion goes through multiple validations | |
| <br> | |
| You can review suggested areas to improve or retry once updates have been made. | |
| to ensure the generated code is secure and error-free. In this | |
| <br> | |
| Read more in our | |
| case, we were unable to generate a quality fix and must refer | |
| <br> | |
| you to the Fix Analysis and Issue Overview for manual | |
| <br> | |
| remediation of the issue. | |
| <br> | |
| For more information on the limitations and validations for Agent Fix, see our | |
| <a class="styled-link" href="https://docs.snyk.io/scan-with-snyk/snyk-code/manage-code-vulnerabilities/fix-code-vulnerabilities-automatically#limitations"> | |
| [documentation] | |
| </a> | |
| <p>We attempted to generate a fix, but the suggestions did not pass validation. Each generated fix suggestion goes through multiple validations to ensure the generated code is secure and error-free.</p> | |
| <p>In this case, we were unable to generate a quality fix and must refer you to the Fix Analysis and Issue Overview for manual remediation of the issue.</p> | |
| <p>For more information on the limitations and validations for Agent Fix, see our <a class="styled-link" href="https://docs.snyk.io/scan-with-snyk/snyk-code/manage-code-vulnerabilities/fix-code-vulnerabilities-automatically#limitations">documentation</a>.</p> |
…IDE-1598] Adjust the line breaks in the AI fix unavailable message to match the reference line width and split the validation explanation into three evenly balanced lines for better readability.
Description
Updates the message displayed when AI fixes cannot be generated to provide clearer guidance to users about the validation process.
Changes:
Related Jira: IDE-1598
Updated wording

Previous

Checklist
make generate)make lint-fix)