make LexFlags hidden or pub(crate) when necessary#608
Merged
ltratt merged 1 commit intosoftdevteam:masterfrom Oct 22, 2025
Merged
make LexFlags hidden or pub(crate) when necessary#608ltratt merged 1 commit intosoftdevteam:masterfrom
LexFlags hidden or pub(crate) when necessary#608ltratt merged 1 commit intosoftdevteam:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working through variations of the
%grmtoolssection API/before we landed on the shared parser between lrlex/lrpar in cfgrammar.LexFlagshad at times taken a more visible place in the API with the lrlex section parser building aLexFlagsstructure directly.It feels like the last
pubbits of this can behiddenand madepub (crate)though.