Skip to content

chore(deps): upgraded to latest dependencies#242

Open
Sourav-kashyap wants to merge 1 commit intomasterfrom
ratelimiter
Open

chore(deps): upgraded to latest dependencies#242
Sourav-kashyap wants to merge 1 commit intomasterfrom
ratelimiter

Conversation

@Sourav-kashyap
Copy link

Description

Upgraded loopback4-ratelimiter to use the latest versions of rate-limiting dependencies, migrate from older versions to the latest stable releases.

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine

Build Passed:

Screenshot 2026-03-20 at 3 35 24 PM

TestCases Passed:

Screenshot 2026-03-20 at 3 35 42 PM

@Sourav-kashyap Sourav-kashyap self-assigned this Mar 20, 2026
@Sourav-kashyap Sourav-kashyap added the dependencies Pull requests that update a dependency file label Mar 20, 2026
@Sourav-kashyap Sourav-kashyap force-pushed the ratelimiter branch 4 times, most recently from f48b3d6 to 6592e7f Compare March 20, 2026 13:19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be removed all together

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@yeshamavani
Copy link
Contributor

@Sourav-kashyap trivy failing

upgraded to latest dependencies

GH-0
@sonarqubecloud
Copy link

SonarQube reviewer guide

Summary: Upgrade dependencies significantly, including express-rate-limit from v6 to v8, and update related packages to compatible versions.

Review Focus:

  • express-rate-limit v8 introduces breaking changes: the name option is no longer supported, and store instances cannot be reused. The code now caches RateLimiter instances and filters unsupported options.
  • Type definitions have changed for rate-limit stores (MemcachedStore, RedisStore now use named exports).
  • Node.js minimum version bumped to 20 for several dependencies (husky, commitlint, jsdom, typescript).
  • Major dependency updates: jsdom (21 → 29), typescript (5.2.2 → 5.5.4), husky (7 → 9), semantic-release plugins updated.

Start review at: src/providers/ratelimit-datasource.provider.ts. This file is critical because it handles the creation of rate-limit stores (Memcached, Mongo, Redis) and demonstrates how to work with the updated package imports and types.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
48.4% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants