Add JSU Compiler with JMC Backend for C, Python, Java, JS and Perl.#180
Add JSU Compiler with JMC Backend for C, Python, Java, JS and Perl.#180jviotti merged 24 commits intosourcemeta-research:mainfrom
Conversation
|
Try to merge |
|
Hey @zx80, just a note that I’ve seen the notifications and will get into it as soon as possible. Quite busy this week with something else + a bit of travel
… On 12 Mar 2026, at 08:26, Fabien ***@***.***> wrote:
@zx80 commented on this pull request.
In implementations/jsu-py/version.sh:
> @@ -0,0 +1,2 @@
+#! /bin/sh
+docker run --rm --entrypoint /app/jsu_version.sh jsonschema-benchmark/jsu-c:latest Python
I've done 5 independent dockerfile (I added Java), which as a pain, as I expected.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
--
Juan Cruz Viotti
https://www.sourcemeta.com
|
|
@michaelmior You might want to review this too in the mean-time! |
|
Hmmm, the
I guess shell limits are reached after adding 5 implementations, some re-engineering will be needed. printf "${OUTPUTS}" | awk 'NR==1 || !/^implementation,/' > dist/report.csvThe OUTPUTS environment variable contains the whole CSV file contents, which must be over 128 kB… |
|
I succeeded in updating the CI to use artifact uploads instead of output transfers so as to avoid failing on the maximum size of an environment variable. Now the aggregate tasks fails on missing crendentials when uploading the results, which is the usual. |
|
I left a comment regarding pipes but otherwise looks good. @michaelmior can you also do a pass on this, as you wrote the vast majority of the surrounding scripts for measuring, etc? |
|
Hello Juan, I'm unsure about what I can do to help this PR move forward. FYI, in complement to JSU Python backend variant and thanks to Julian, the JSU C, Java, JS and Perl backend variants have been integrated (C commit and Java/JS/Perl commit) to bowtie, thus should be listed on the next report update. The August PR (a resubmission of this May PR that I wrongly thought had been merged) about listing these tools on the JSON Schema website seems as stuck as ever. |
|
Overall I think this is looking good although there are several minor things that should be addressed. |
I think that I've addressed everything in the above push. |
Great! Thanks! When do you think it may be merged? |
|
@zx80 Its pending @michaelmior 's re-review. I can't merge given the requested changes.
|
|
Ok! |
|
Ping @michaelmior |
|
Sorry for the delay. I resolved my review so feel free to merge! @jviotti note that as an admin, you should be able to dismiss my review yourself to meet the merge requirements. |
|
@michaelmior Ah, looks like it was not the case, but maybe some repo settings we could tweak. As per my screenshot above, I could not merge indeed. |
|
Thanks for the reviews and the merge! |

This uses the JSU compiler which uses JMC as a backend for Python, C, Java, JS and Perl.