Draft
Conversation
Triggered by 38beb37 on branch refs/heads/key-migration-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Rerunning
run_key_migration_functionsno longer grants collection access to users who did not previously have it. Also fixed the app resource directory duplication issue that caused institution-level app resource permissions to appear broken.Made running the key migrations function optional at startup with
RUN_KEY_MIGRATION_ON_STARTUP=0in the .env file.Split default permission initialization from legacy user/collection permission migration, so now the key migrations used to run only the default permission seeding path, not the legacy user assignment path.
Hardened discipline app resource dir repair logic to reuse legacy rows with blank
usertype, normalize those rows, consolidate duplicate discipline directories, and move persisted app resources/viewsets onto the canonical directory before deleting duplicatesAdded a follow-up migration to repair existing duplicated discipline app resource dirs.
Checklist
self-explanatory (or properly documented)
Testing instructions
TBD