Skip to content

Upgrade RuboCop from 0.63.1 to 1.85.0 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agrberg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade RuboCop from 0.63.1 to 1.85.0 #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
AllCops:
TargetRubyVersion: 2.6
NewCops: disable
SuggestExtensions: false
Exclude:
- 'gemfiles/**/*'
- Appraisals
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ gem 'appraisal'
gem 'pry-byebug'
gem 'rake'
gem 'rspec'
gem 'rubocop', '0.63.1'
gem 'rubocop'

gemspec
2 changes: 1 addition & 1 deletion gemfiles/activesupport_7_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ gem "appraisal"
gem "pry-byebug"
gem "rake"
gem "rspec"
gem "rubocop", "0.63.1"
gem "rubocop"
gem "activesupport", "~> 7.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/activesupport_7_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ gem "appraisal"
gem "pry-byebug"
gem "rake"
gem "rspec"
gem "rubocop", "0.63.1"
gem "rubocop"
gem "activesupport", "~> 7.1"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/activesupport_7_2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ gem "appraisal"
gem "pry-byebug"
gem "rake"
gem "rspec"
gem "rubocop", "0.63.1"
gem "rubocop"
gem "activesupport", "~> 7.2"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/activesupport_8_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ gem "appraisal"
gem "pry-byebug"
gem "rake"
gem "rspec"
gem "rubocop", "0.63.1"
gem "rubocop"
gem "activesupport", "~> 8.0"

gemspec path: "../"
4 changes: 2 additions & 2 deletions lib/rrule/humanizer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def yearly

add list(options.fetch(:bymonth), method(:monthtext), 'and') if bymonth_option

add list (bymonthday_option.map { |o| nth(o) }), :to_s, 'and' if bymonthday_option
add list(bymonthday_option.map { |o| nth(o) }, :to_s, 'and') if bymonthday_option
end

def weekly
Expand Down Expand Up @@ -220,7 +220,7 @@ def _byweekday

def _bymonthday
add 'on the'
add list (bymonthday_option.map { |o| nth(o) }), :to_s, 'and'
add list(bymonthday_option.map { |o| nth(o) }, :to_s, 'and')
end

def _byhour
Expand Down