chore(dkg): mark SIP 1 as superseded by ssv-dkg#92
Open
oleg-ssvlabs wants to merge 1 commit intomainfrom
Open
Conversation
- Add note pointing readers to ssvlabs/ssv-dkg and ssvlabs/dkg-spec, where the active DKG implementation and spec live. - Remove stale "TODO - missing proof of possession for the pubkey?" left in the SIP since 2022. - Fix broken Markdown link to the discussion thread. Closes ssvlabs/ssv-node-board#516 Co-Authored-By: Claude <noreply@anthropic.com>
| @@ -2,7 +2,16 @@ | |||
| |-------------|--------------------------------|----------|---------------------|------------| | |||
| | Alon Muroch | Generalized DKG support in SSV | Core | open-for-discussion | 2022-06-27 | | |||
There was a problem hiding this comment.
suggestion: Header row reads open-for-discussion while the note below says the SIP is superseded. sips/qbft_sync.md:4 already uses Deprecated without any SIP 0 amendment — non-lifecycle statuses are accepted in practice.
Suggested change
| | Alon Muroch | Generalized DKG support in SSV | Core | open-for-discussion | 2022-06-27 | | |
| | Alon Muroch | Generalized DKG support in SSV | Core | Superseded | 2022-06-27 | |
Comment on lines
+7
to
+14
| > **Note:** This SIP is no longer actively developed. The DKG protocol for SSV | ||
| > is implemented in [`ssvlabs/ssv-dkg`](https://github.com/ssvlabs/ssv-dkg) | ||
| > with its specification maintained in | ||
| > [`ssvlabs/dkg-spec`](https://github.com/ssvlabs/dkg-spec). This document | ||
| > is kept for historical reference only; design details below do not reflect | ||
| > the current implementation. The SIP lifecycle defined in [SIP 0](./sip0.md) | ||
| > does not currently include a `superseded` state, so the header status is | ||
| > left unchanged. |
There was a problem hiding this comment.
Note phrases ssv-dkg/dkg-spec as implementing this SIP's protocol, not as a successor with divergent design. Readers chasing the redirect to understand current DKG risk over-trusting the non-normative protocol below.
> **Note:** This SIP is no longer actively developed. DKG for SSV is now provided by
> [`ssvlabs/ssv-dkg`](https://github.com/ssvlabs/ssv-dkg) and
> [`ssvlabs/dkg-spec`](https://github.com/ssvlabs/dkg-spec), which follow a **different
> design** than the protocol described below. This document is kept for historical
> reference only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ssvlabs/ssv-node-board#516
Summary
SIP 1 (DKG) has been
open-for-discussionsince 2022-06-27 and contains a long-standing// TODO - missing proof of possession for the pubkey?marker. The actual DKG implementation for SSV has lived inssvlabs/ssv-dkgwith its spec inssvlabs/dkg-specfor some time, and the two have diverged substantially from this SIP (different transport, different signing/encryption, added Resign/Reshare operations, etc.).The SIP lifecycle defined in SIP 0 doesn't currently include a
supersededstate, so the header status is left asopen-for-discussion. Instead, this PR adds an in-document note pointing readers to the real implementation/spec, so nobody treats this SIP as load-bearing.Changes
sips/dkg.mdpointing tossvlabs/ssv-dkgandssvlabs/dkg-spec.// TODO - missing proof of possession for the pubkey?comment from theSignedSessionPubKeysection.[Discussion] (...)→[Discussion](...)).Notes
sips/sip0.mdto add asupersededstatus and then mark DKG SIP accordingly. Intentionally out of scope here.