Merged
Conversation
Member
COil
commented
Apr 18, 2026
- https://symfony.com/blog/symfony-8-0-8-released
| Q | A |
|---|---|
| Branch? | main |
| Cleanup? | no |
| Bug fix? | no |
| New feature? | yes |
| Doc added? | no |
| Tests pass? | yes |
| Deprecations? | no |
There was a problem hiding this comment.
Pull request overview
Updates the project’s dependency set to align with the Symfony 8.0.8 release (and associated ecosystem bumps), plus a small test annotation tweak.
Changes:
- Bump Symfony (and related) packages in
composer.lockto newer patch versions. - Update tooling dependencies in
vendor-bin/php-cs-fixer/composer.lock(including php-cs-fixer). - Add a PHPDoc type annotation in the static routes smoke test.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vendor-bin/php-cs-fixer/composer.lock | Updates php-cs-fixer toolchain lockfile and transitive deps. |
| tests/Functional/Controller/StaticRoutesSmokeTest.php | Adds a PHPDoc annotation for route variables in the smoke test. |
| composer.lock | Updates application dependencies (Symfony 8.0.8 and related package bumps). |
Comments suppressed due to low confidence (1)
tests/Functional/Controller/StaticRoutesSmokeTest.php:61
- The PHPDoc type for
$variableslooks incorrect:$route->compile()->getVariables()returns route variable names (strings), but the annotation declares\Stringable. This can mislead static analysis and IDEs; annotate it asarray<int, string>(orlist<string>) to match the actual values used witharray_diff()against$defaultsKeys(strings).
/** @var array<int, \Stringable> $variables */
$variables = $route->compile()->getVariables();
if (\count($variables) > 0) {
$defaults = $route->getDefaults();
$defaultsKeys = array_keys($defaults);
$diff = array_diff($variables, $defaultsKeys);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ec24dfd to
0673dbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.