Skip to content

Symfony 8.0.8 update#253

Merged
COil merged 2 commits intomainfrom
chore/symfony-update
Apr 18, 2026
Merged

Symfony 8.0.8 update#253
COil merged 2 commits intomainfrom
chore/symfony-update

Conversation

@COil
Copy link
Copy Markdown
Member

@COil COil commented Apr 18, 2026

Q A
Branch? main
Cleanup? no
Bug fix? no
New feature? yes
Doc added? no
Tests pass? yes
Deprecations? no

@COil COil self-assigned this Apr 18, 2026
Copilot AI review requested due to automatic review settings April 18, 2026 14:15
@COil COil added the chore chore or cleanup label Apr 18, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s dependency set to align with the Symfony 8.0.8 release (and associated ecosystem bumps), plus a small test annotation tweak.

Changes:

  • Bump Symfony (and related) packages in composer.lock to newer patch versions.
  • Update tooling dependencies in vendor-bin/php-cs-fixer/composer.lock (including php-cs-fixer).
  • Add a PHPDoc type annotation in the static routes smoke test.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
vendor-bin/php-cs-fixer/composer.lock Updates php-cs-fixer toolchain lockfile and transitive deps.
tests/Functional/Controller/StaticRoutesSmokeTest.php Adds a PHPDoc annotation for route variables in the smoke test.
composer.lock Updates application dependencies (Symfony 8.0.8 and related package bumps).
Comments suppressed due to low confidence (1)

tests/Functional/Controller/StaticRoutesSmokeTest.php:61

  • The PHPDoc type for $variables looks incorrect: $route->compile()->getVariables() returns route variable names (strings), but the annotation declares \Stringable. This can mislead static analysis and IDEs; annotate it as array<int, string> (or list<string>) to match the actual values used with array_diff() against $defaultsKeys (strings).
            /** @var array<int, \Stringable> $variables */
            $variables = $route->compile()->getVariables();
            if (\count($variables) > 0) {
                $defaults = $route->getDefaults();
                $defaultsKeys = array_keys($defaults);
                $diff = array_diff($variables, $defaultsKeys);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@COil COil force-pushed the chore/symfony-update branch from ec24dfd to 0673dbe Compare April 18, 2026 14:18
@COil COil merged commit 2b68386 into main Apr 18, 2026
4 checks passed
@COil COil deleted the chore/symfony-update branch April 18, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore chore or cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants