Skip to content

Adds -profile:v and -pix_fmt flag options to encoding_options.rb #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mishaux wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adds -profile:v and -pix_fmt flag options to encoding_options.rb #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22ba206
Add profile:v setting to encoding options.
Mishaux Mar 18, 2017
a11197d
change name of profile option in encoding_options.rb
Mishaux Mar 18, 2017
acf0c67
Add pix_fmt option to encoding_options
Mishaux Mar 19, 2017
932acbe
Add specs
Mishaux Mar 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/ffmpeg/encoding_options.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,14 @@ def convert_watermark(value)
["-i", value]
end

def convert_profile(value)
["-profile:v", value]
end

def convert_pix_fmt(value)
["-pix_fmt", value]
end

def convert_watermark_filter(value)
position = value[:position]
padding_x = value[:padding_x] || 10
Expand Down
8 changes: 8 additions & 0 deletions spec/ffmpeg/encoding_options_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,14 @@ module FFMPEG
expect(EncodingOptions.new(screenshot: true, vframes: 123, quality: 3).to_a).to eq(%w(-f image2 -vframes 123 -q:v 3))
end

it "should accept and set profile:v" do
expect(EncodingOptions.new(profile: "baseline").to_a).to eq(%w(-profile:v baseline))
end

it "should accept and set pix_fmt" do
expect(EncodingOptions.new(pix_fmt: "yuv420p").to_a).to eq(%w(-pix_fmt yuv420p))
end

it 'should put the parameters in order of codecs, presets, others' do
opts = Hash.new
opts[:frame_rate] = 25
Expand Down