fix(deploy): nil pointer dereference when creating new machines during deploy#4750
Open
fix(deploy): nil pointer dereference when creating new machines during deploy#4750
Conversation
…g deploy When scaling up (oldMachine=nil), updateMachineWChecks accessed oldMachine.ID for the health check wait log message, causing a panic. Use the machine returned from updateOrCreateMachine instead, which is guaranteed non-nil at that point.
dangra
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateMachineWChecksthat occurs when scaling up (creating new machines with no corresponding old machine).oldMachineis nil (new machine being created), the health check wait log message atplan.go:562accessedoldMachine.ID, causing a SIGSEGV. Changed to usemachine.ID(the return value fromupdateOrCreateMachine) which is guaranteed non-nil at that point.TestUpdateMachinesWithNewMachineto exercise this exact code path: deploying with a new machine in the app state that has no old machine counterpart, with smoke checks enabled.