[stdlib] Generalize withContiguous[Mutable]StorageIfAvailable for typed throws#88534
Open
clintonpi wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
Author
|
@swift-ci please benchmark |
NotTheNHK
reviewed
Apr 17, 2026
| #if hasFeature(Embedded) | ||
| return try base.withContiguousStorageIfAvailable(body) | ||
| #else // hasFeature(Embedded) | ||
| do { |
Contributor
There was a problem hiding this comment.
Can't we use do throws(E) here? So we don't have to force cast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withContiguousStorageIfAvailableandwithContiguousMutableStorageIfAvailableas requirements forSequenceandMutableCollectionprotocols respectively.@_alwaysEmitIntoClient. This makes their concrete implementations less preferred witnesses, ranking their default implementations higher. Therefore, this PR also marks their default implementations as@_disfavoredOverloadso their concrete implementations stay preferred.