fix: security hardening and documentation improvements#177
Merged
Conversation
437c534 to
1578abb
Compare
📊 Output Delta ReportGenerated RBAC resources from Prometheus Metrics (PR branch)📈 auth_operator_* metrics
|
📊 Output Delta Report (cont.)📦 BindDefinitions StatusChanges from
|
88148ba to
718e201
Compare
Address security and documentation items from issues #143 and #158. Closes #143. Closes #158. - SEC-011: Sanitize error messages in CRD status conditions to avoid leaking internal details. Log full errors for operator admins. - SEC-012: Document bypass account hardcoding rationale (already comprehensively documented in upstream, verified complete). - SEC-013: Add CVE-2023-44487 and CVE-2023-39325 rationale comment to the --enable-http2 flag explaining why HTTP/2 is disabled. - Update AutomountServiceAccountToken field description with security implications and least-privilege guidance. - Regenerate CRDs, docs, and Helm chart after types change.
Call sites already log the error at Error level before calling markStalled. Log at V(1) debug level instead to maintain observability without noise.
718e201 to
20ff088
Compare
- Replace raw err.Error() with sanitized message in BindDefinition and WebhookAuthorizer markStalled to prevent internal error leakage - Simplify RoleDefinition markStalled message to avoid redundant prefix - Add debug-level error logging in all markStalled functions - Update tests to match new sanitized messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security hardening and documentation improvements. Closes #143, #158.
Changes
SEC-011: Error Message Sanitization
SEC-013: HTTP/2 CVE Documentation
comment to the
--enable-http2flagIssue #143: AutomountServiceAccountToken Security Docs
SEC-012: Bypass Account Documentation
Testing
make fmt vet lint- 0 issuesmake test- all tests pass with race detectormake manifests generate docs helm- no additional changes