Bump qr dependency to v0.0.3#786
Closed
limpbrains wants to merge 12 commits intoteslamotors:masterfrom
Closed
Conversation
Selectively synced upstream changes while preserving QR-only Android implementation.
Changes auto-synced (Category A - 19 files):
- iOS: All 8 files (stress test support + allowedBarcodeTypes filtering)
- TypeScript: All 7 files (Camera components, props, types, specs)
- Example app: All 3 files (stress test + allowedBarcodeTypes example)
- Config: Moved .nvmrc to root
Changes selectively synced (Category B - 2 files):
- CodeFormat.kt: Added UPC_A("upc-a") enum value (1 hunk applied, 1 skipped)
- README.md: Added allowedBarcodeTypes docs with QR-only note
Changes skipped (Android barcode conflicts):
- CKCamera.kt: All barcode filtering logic (~50+ hunks)
Reason: Fork uses onBarcodeRead(String), upstream uses onBarcodeRead(List<Barcode>, Size)
- CKCameraManager.kt: setAllowedBarcodeTypes property setter
- package.json: Version bump (fork maintains independent versioning)
Upstream range: 5a709e0..cc6515b (12 commits)
Main feature: allowedBarcodeTypes barcode filtering (iOS synced, Android QR-only preserved)
Fork integrity checks:
✅ No Google ML Kit dependencies
✅ QRDecoder.decode() preserved
✅ limpbrains/qr dependency intact
✅ yarn build && yarn lint passed
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Upgrade from v0.0.1 to v0.0.2 for new features: - ECI (Extended Channel Interpretation) support for 20+ character encodings - Inverted QR code detection (white-on-black QR codes) Build and lint verified passing. 🤖 Generated with Claude Code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
After syncing TypeScript layer with allowedBarcodeTypes and iOsSleepBeforeStarting props, the auto-generated CKCameraManagerInterface requires these methods to be implemented. Added stub implementations in both newarch and oldarch: - setAllowedBarcodeTypes: No-op (fork is QR-only, doesn't use filtering) - setIOsSleepBeforeStarting: No-op (iOS-only prop) Both methods accept the props for API compatibility but have no effect on Android. Verified: Android build now compiles successfully 🤖 Generated with Claude Code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
## What's Changed ### Upstream Sync (teslamotors/react-native-camera-kit@cc6515b) - iOS: Added allowedBarcodeTypes barcode filtering and mount stress test support - TypeScript: Added allowedBarcodeTypes prop with type definitions - Example app: Added stress test and barcode filtering examples - Config: Moved .nvmrc to root directory - Docs: Added allowedBarcodeTypes documentation with fork notes ### Android Improvements - Fixed build error by adding Codegen-required stub implementations - Updated to limpbrains/qr v0.0.2 (ECI encoding + inverted QR code support) - Preserved QR-only scanning architecture (no Google ML Kit) ### Fork Integrity ✅ Build and lint tests pass ✅ No Google ML Kit dependencies ✅ QR-only Android barcode scanning preserved 🤖 Generated with Claude Code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates com.github.limpbrains:qr from v0.0.2 to v0.0.3 in android/build.gradle