Conversation
matoszz
requested review from
adelowo,
golanglemonade and
theopenlane-bender
|
golanglemonade
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of changes to sleuth, realized httpsling lacked typed error response decoding so I added
OnError(v any)andReceiveIntoWithError[S, E any]so callers can decode 2xx and 4xx/5xx into separate structs in a single callAlso fixed several bugs while I was in here: nil panic in IsSuccess, fragile media type parsing in generalMediaType, redundant strings.ToLower inside strings.EqualFold, and a slice mutation bug in ReceiveIntoWithError. Pulled in all outstanding dependencies.