Feat(storage): add bucket encryption enforcement#13
Conversation
Adds metadata support for the following encryption enforcement fields: - googleManagedEncryptionEnforcementConfig - customerManagedEncryptionEnforcementConfig - customerSuppliedEncryptionEnforcementConfig
Summary of ChangesHello @thiyaguk09, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances Google Cloud Storage bucket management by introducing robust capabilities for encryption enforcement. It provides users with the tools to programmatically define, inspect, and reset encryption policies across various key management types, thereby strengthening data security and compliance within their storage infrastructure. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds functionality to manage bucket encryption enforcement configurations, including setting, getting, and removing them. The changes are well-implemented and include corresponding tests. My review includes a suggestion to improve the robustness of the new tests to ensure they correctly validate the behavior.
Updates the encryption enforcement sample to a single consolidated file under the `storage_update_encryption_enforcement_config` region tag. The updated sample now covers both partial updates (restriction modes) and the full removal of enforcement configurations.
Updates the region tags to include the 'bucket' keyword for better consistency with other GCS samples: - storage_get_bucket_encryption_enforcement_config - storage_update_bucket_encryption_enforcement_config - storage_set_bucket_encryption_enforcement_config
- Refactor `set_bucket_encryption_enforcement_config` to apply enforcement settings during bucket creation instead of a separate update call. - Rename test variable to `$enforcementBucketName` to better align with `BucketEncryptionEnforcementConfig`. - Update PHPUnit test suite to use a dependent data-passing flow for improved reliability and cleaner logic.
Adds metadata support for the following encryption enforcement fields: