Skip to content

Feat(storage): add bucket encryption enforcement#13

Closed
thiyaguk09 wants to merge 7 commits intomainfrom
feat/bucket-encryption-config
Closed

Feat(storage): add bucket encryption enforcement#13
thiyaguk09 wants to merge 7 commits intomainfrom
feat/bucket-encryption-config

Conversation

@thiyaguk09
Copy link
Copy Markdown
Owner

Adds metadata support for the following encryption enforcement fields:

  • googleManagedEncryptionEnforcementConfig
  • customerManagedEncryptionEnforcementConfig
  • customerSuppliedEncryptionEnforcementConfig

Adds metadata support for the following encryption enforcement fields:
- googleManagedEncryptionEnforcementConfig
- customerManagedEncryptionEnforcementConfig
- customerSuppliedEncryptionEnforcementConfig
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @thiyaguk09, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances Google Cloud Storage bucket management by introducing robust capabilities for encryption enforcement. It provides users with the tools to programmatically define, inspect, and reset encryption policies across various key management types, thereby strengthening data security and compliance within their storage infrastructure.

Highlights

  • New Encryption Enforcement Configuration Retrieval: Added a new function get_bucket_encryption_enforcement_config to retrieve and display the current encryption enforcement settings for a given Google Cloud Storage bucket, including details for Google Managed, Customer Managed, and Customer Supplied Encryption.
  • New Encryption Enforcement Configuration Setting: Implemented a new function set_bucket_encryption_enforcement_config that allows configuring a bucket to enforce specific encryption types, such as requiring Customer Managed Encryption Keys (CMEK) while restricting others.
  • New Encryption Enforcement Configuration Removal: Introduced a new function remove_all_bucket_encryption_enforcement_config to clear all encryption enforcement configurations from a bucket, effectively reverting to default behavior.
  • Comprehensive Test Coverage: Added dedicated unit tests to validate the functionality of setting, retrieving, and removing bucket encryption enforcement configurations, ensuring reliability and correctness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • storage/src/get_bucket_encryption_enforcement_config.php
    • Added new file for retrieving bucket encryption enforcement configurations.
  • storage/src/remove_all_bucket_encryption_enforcement_config.php
    • Added new file for removing all bucket encryption enforcement configurations.
  • storage/src/set_bucket_encryption_enforcement_config.php
    • Added new file for setting bucket encryption enforcement configurations.
  • storage/test/storageTest.php
    • Added testSetBucketEncryptionEnforcementConfig to verify setting encryption enforcement.
    • Added testGetBucketEncryptionEnforcementConfig to verify retrieving encryption enforcement.
    • Added testRemoveAllBucketEncryptionEnforcementConfig to verify removing all encryption enforcement.
Activity
  • The pull request was created by thiyaguk09, introducing new features for Google Cloud Storage bucket encryption enforcement.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds functionality to manage bucket encryption enforcement configurations, including setting, getting, and removing them. The changes are well-implemented and include corresponding tests. My review includes a suggestion to improve the robustness of the new tests to ensure they correctly validate the behavior.

Updates the encryption enforcement sample to a single consolidated file
under the `storage_update_encryption_enforcement_config` region tag.
The updated sample now covers both partial updates (restriction modes)
and the full removal of enforcement configurations.
Updates the region tags to include the 'bucket' keyword for better
consistency with other GCS samples:
- storage_get_bucket_encryption_enforcement_config
- storage_update_bucket_encryption_enforcement_config
- storage_set_bucket_encryption_enforcement_config
- Refactor `set_bucket_encryption_enforcement_config` to apply
enforcement settings during bucket creation instead of a separate update
call.
- Rename test variable to `$enforcementBucketName` to better align with
`BucketEncryptionEnforcementConfig`.
- Update PHPUnit test suite to use a dependent data-passing flow for
improved reliability and cleaner logic.
@thiyaguk09 thiyaguk09 closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant