Skip to content

don't delete gws in grace period #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashraffouda merged 1 commit into from
Mar 17, 2026
Merged

don't delete gws in grace period #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/gateway/gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const (
var (
ErrTwinIDMismatch = fmt.Errorf("twin id mismatch")
ErrContractNotReserved = fmt.Errorf("a name contract with the given name must be reserved first")
ErrInvalidContractState = fmt.Errorf("the name contract must be in Created state")
ErrInvalidContractState = fmt.Errorf("the name contract must be in Created or GracePeriod state")

_ pkg.Gateway = (*gatewayModule)(nil)
)
Expand Down Expand Up @@ -545,7 +545,7 @@ func (g *gatewayModule) validateNameContract(name string, twinID uint32) error {
} else if subErr.IsError() {
return subErr.Err
}
if !contract.State.IsCreated {
if !contract.State.IsCreated && !contract.State.IsGracePeriod {
return ErrInvalidContractState
}
if uint32(contract.TwinID) != twinID {
Expand Down
4 changes: 2 additions & 2 deletions pkg/gateway_light/gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const (
var (
ErrTwinIDMismatch = fmt.Errorf("twin id mismatch")
ErrContractNotReserved = fmt.Errorf("a name contract with the given name must be reserved first")
ErrInvalidContractState = fmt.Errorf("the name contract must be in Created state")
ErrInvalidContractState = fmt.Errorf("the name contract must be in Created or GracePeriod state")

_ pkg.Gateway = (*gatewayModule)(nil)
)
Expand Down Expand Up @@ -556,7 +556,7 @@ func (g *gatewayModule) validateNameContract(name string, twinID uint32) error {
} else if subErr.IsError() {
return subErr.Err
}
if !contract.State.IsCreated {
if !contract.State.IsCreated && !contract.State.IsGracePeriod {
return ErrInvalidContractState
}
if uint32(contract.TwinID) != twinID {
Expand Down
Loading